Time Hannah-T

[stpatrickschild]

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote a self method named spotlight. The method looks up for all the votes, then makes groups using the work_id, then counts all the votes for each work, I used sort and first methods to get the work with votes.
Describe how you approached testing that model method. What edge cases did you come up with?	This is the place I spent the least amount of time, I used most of my time on the logic and erb. My plan is after submitting the assignment to go back and write the test and make it look prettier.
What are session and flash? What is the difference between them?	Both are used to to send messages to the views. We use flash for success, errors or failures at the controllers. We use session to keep track of data throughout a users "session", which normally ends when they close their browser, clear history or it expires.
What was one thing that you gained more clarity on through this assignment?	I used the rails routes on terminal to get better understanding of the prefix, that argument it took. I also used the buybug rails c command to debugg and get most of my answers. I also enjoyed/got challenge/learned a ton about partials and refactoring.
What is the Heroku URL of your deployed application?	https://hmt-media-ranker.herokuapp.com

Assignment Submission: Media Ranker

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What was a custom model method you wrote? What was it responsible for doing?
Describe how you approached testing that model method. What edge cases did you come up with?
What are session and flash? What is the difference between them?
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application?

[jmaddox19]

Media Ranker

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	✔️ Movies is missing data but not a big deal :)
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message	✔️
4. Can edit this work successfully, and get a flash message	✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote	✔️
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	Validation errors are not visible to the user
7. Can create a new work successfully. Note the URL for this work's show page	✔️
8. Can delete this work successfully	✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	✔️ Yes, but there are ways this could be improved. (See my inline comments in the show action for more details.)
10. Verify that the "View all users" page lists no users	✔️
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons	✔️
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight	✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page	✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	The app allows me to vote on the same work multiple times.
Log out	--
16. Logging out showed a flash message and changed the UI	✔️
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku	✔️
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker	✔️
3. Practices git with at least 25 small commits and meaningful commit messages	Commits looks good but more commits would be highly recommended

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses resources for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	Many extra routes setup. (See inline comments on routes.rb for more context.)
6. The homepage view, all media view, and new works view use semantic HTML	✔️ Yes!
7. The homepage view, all media view, and new works view use partials when appropriate	✔️ Yes!
8. The model for media (likely named work.rb) has_many votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category	✔️
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user	✔️
11. Some controller, likely the WorksController, has a controller filter for finding a work	✔️
12. The WorksController uses strong params	✔️
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash	✔️

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	Validations tests are there but none on relationships
18. Work model has tests with a section on all business logic methods in the model, including their edge cases

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	14+ in Functional Requirements: Manual Testing && 14+ in Code Review
Yellow (Approaches Standards)	12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention	✔️ Looks great! Would have been green if testing were complete :)
Red (Not at Standard)	0-10 in Code Review or 0-11 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[jmaddox19]

This works! However, because you used render rather than redirect, the path is not updated to reflect the show action. Typically in a case like this it's better to use redirect instead.

[jmaddox19]

This follows the initial example that we gave for handling not found in the show action but in later lessons we moved from this to redirecting and presenting the user with a flash message explaining what went wrong.
This produces a more user-friendly flow than the default rails error, which doesn't allow the user to click anything to navigate back to the web application.

[jmaddox19]

This creates the 7 restful routes for the VotesController even though none of those exist. Because the only action this controller has is the upvote action, this line is not needed.

[jmaddox19]

You can run rails routes from the terminal to see all the routes setup that are non-existent in the controller.

[jmaddox19]

This also creates all 7 restful routes when only index and show are actually setup in the controller.

Suggested change

	resources :users
	resources :users, only: [:index, :show]