Space - Katie#52
Open
ktvoort123 wants to merge 35 commits into
Open
Conversation
…d in, and to see current user info and log out if logged in
…ethod in work model to count total votes" ;
… to user controller
… model and updated the homepages view and controller
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
kaidamasaki
reviewed
Jun 4, 2020
kaidamasaki
left a comment
kaidamasaki
left a comment
There was a problem hiding this comment.
Great job! You missed a few small things (you can make better use of view partials and should go over controller filters again) but overall this was a really good solution. 😃
Comment on lines
+7
to
+11
| @work = Work.find_by(id: params[:id]) | ||
| if @work.nil? | ||
| head :not_found | ||
| return | ||
| end |
There was a problem hiding this comment.
This logic is repeated several times and should be placed in a controller filter to DRY up your code.
Comment on lines
+10
to
+11
| <p class="spotlight__description"><%=@top_work.num_votes%> votes - | ||
| </p> |
There was a problem hiding this comment.
Your indentation is a little funky in some places.
| </thead> | ||
|
|
||
| <tbody> | ||
| <% @works.where(category: category).sort_by{|work| work.num_votes}.reverse.each do |work| %> |
There was a problem hiding this comment.
This logic should have been in your model or a view helper.
Comment on lines
+5
to
+6
| resources :users | ||
| resources :votes |
There was a problem hiding this comment.
Remember, unless you implement all 7 actions you should exclude unused ones in your routes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?