Yolotzin - Time#54
Open
ydunbar wants to merge 61 commits into
Open
Conversation
…laceholder header in the application view
…nks in Work show view
…er, with session routes and ERB login form and current view
Media RankerFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
Testing Rails Apps
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?) SummaryTo be clear your testing is very rough. You have a lot of things to work on there. You did get the basic functionality working. Take a look at my inline comments. I'd like you to particularly pay attention to my comments on testing and see what you can do to do better there in the bEtsy project. Maybe take on this responsibility with your team so that you can improve. |
CheezItMan
reviewed
Jun 4, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Note: You are indenting with 4 spaces instead of 2. At Ada our standard indentation is 2 spaces.
Comment on lines
+45
to
+49
| it "can get the new_work_path" do | ||
| get new_work_path | ||
|
|
||
| must_respond_with :success | ||
| end |
There was a problem hiding this comment.
This test is failing because you're requiring the user to log in first before they can get to the form.
This would also require you provide a user fixture.
Suggested change
| it "can get the new_work_path" do | |
| get new_work_path | |
| must_respond_with :success | |
| end | |
| it "can get the new_work_path" do | |
| perform_login() | |
| get new_work_path | |
| must_respond_with :success | |
| end |
| end | ||
| end | ||
|
|
||
| describe "create" do |
There was a problem hiding this comment.
These tests also require the user log in first (See above). Also you should test what happens when a guest user tries to create a work.
| # Arrange | ||
| invalid_work_id = -1 | ||
| # Act | ||
| get "/works/#{invalid_work_id}" |
There was a problem hiding this comment.
Suggested change
| get "/works/#{invalid_work_id}" | |
| get work_path(invalid_work_id) |
| end | ||
|
|
||
| def find_work | ||
| @work = Work.find_by_id(params[:id]) |
There was a problem hiding this comment.
You need to do something if the work does not exist.
Suggested change
| @work = Work.find_by_id(params[:id]) | |
| @work = Work.find_by_id(params[:id]) | |
| if @work.nil? | |
| flash[:error] = "That work does not exist" | |
| redirect_to root_path | |
| end |
| }.must_differ 'Work.count', -1 | ||
|
|
||
| must_respond_with :redirect | ||
|
|
| fixtures :all | ||
|
|
||
| # Add more helper methods to be used by all tests here... | ||
| def perform_login(user = nil) |
Comment on lines
+3
to
+6
| <% @work.errors.each do |column, message| %> | ||
| <li> | ||
| <strong><%= column.capitalize %></strong> <%= message %> | ||
| </li> |
Comment on lines
+3
to
+7
| <% @work.errors.each do |column, message| %> | ||
| <li> | ||
| <strong><%= column.capitalize %></strong> <%= message %> | ||
| </li> | ||
| <% end %> |
| @@ -0,0 +1,30 @@ | |||
| class Work < ApplicationRecord | |||
| has_many :votes | |||
There was a problem hiding this comment.
If you want to destroy any votes for this work
Suggested change
| has_many :votes | |
| has_many :votes, dependent: :destroy |
| belongs_to :work | ||
| belongs_to :user | ||
|
|
||
| validates :user_id, uniqueness: { scope: :work_id } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?