Earth/Taylor#32
Open
TaylorMililani wants to merge 13 commits into
Open
Conversation
beccaelenzil
left a comment
beccaelenzil
left a comment
There was a problem hiding this comment.
JS Adagrams
Major Learning Goals/Code Review
| Criteria | yes/no, and optionally any details/lines of code to reference |
|---|---|
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. |
✔️ |
| Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. | ✔️ |
| Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) | ✔️ |
| Uses correct syntax for conditional logic and iteration | ✔️ |
| Practices git with at least 3 small commits and meaningful commit messages | ✔️ |
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures |
✔️ |
Functional Requirements
| Functional Requirement | yes/no |
|---|---|
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) |
✔️ |
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass |
✔️ |
Utilizes unit tests to verify code; all tests for scoreWord pass |
✔️ |
Utilizes unit tests to verify code; all tests for highestScoreFrom pass |
✔️ |
Overall Feedback
Great work on this project! In this project you’ve taken some interesting logic and worked it into JavaScript syntax. Your code is clever and logical. Nice work!
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 5+ in Code Review && 3+ in Functional Requirements | ✔️ |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Elegant/Clever | ✅ |
| Concise | ✅ |
| Logical/Organized | ✅ |
| @@ -1,7 +1,107 @@ | |||
| const letterPool = { | |||
| A: [9, 1], | |||
There was a problem hiding this comment.
I like how you stored the frequency and scores together to DRY up your code.
|
|
||
| usesAvailableLetters(word, hand = drawLetters()) { | ||
| // if letter is found in hand, the search continues at an incremented index. this way a letter in hand cant be counted twice | ||
| return word.toUpperCase().split('').every(( index => letter => index = hand.indexOf(letter, index) + 1)(0)); |
There was a problem hiding this comment.
Wow. This is a lot on one line. Looks slick, but at the same time, consider splitting up this logic to enhance readability.
Comment on lines
+89
to
+99
| for (const word of tiedWords) { | ||
| if (word.length === 10) { | ||
| winningIndex = tiedWords.indexOf(word); | ||
| highestScore = {score: scores[indices[winningIndex]], word: tiedWords[winningIndex]}; | ||
| return highestScore; | ||
| } else { | ||
| if (word.length < shortest.length) { | ||
| shortest = word; | ||
| shortestIndex = tiedWords.indexOf(shortest); | ||
| } | ||
| } |
There was a problem hiding this comment.
Consider breaking out this logic into a helper method such as tieBreaker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: JS Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection