Skip to content

Earth - Lina#33

Open
lina5147 wants to merge 16 commits into
Ada-C14:masterfrom
lina5147:master
Open

Earth - Lina#33
lina5147 wants to merge 16 commits into
Ada-C14:masterfrom
lina5147:master

Conversation

@lina5147

Copy link
Copy Markdown

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I was able to translate hashes to objects, storing key value pairs of the letters and their quantities as well as letters and their scores. There were many areas of this project that I need to iterate through a collection of data. I was able to use this familiar pattern from Ruby and found for of loop in JavaScript to do the trick. I was able to use the if else statement comfortably because it is pretty similar in both languages. The syntax is slightly different.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? No, I used similar strategies when looking up information.
What was something you needed to do independent research on for this project? What did you learn? I had to figure out how to shuffle an array. Generating random numbers is more complex in Javascript. I also learned how to iterate through the key value pairs of an object using the Object.entries() method.
What was a challenge you were able to overcome on this assignment? Figuring out/ debugging the failed tests
What has been interesting and positive about learning a new programming language? Functions are objects and can be passed in as an argument to another function. So crazy!
What is something to focus on your learnings in JavaScript in the next week? I want to focus on debugging.

@beccaelenzil beccaelenzil left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. ✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. ✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures ✔️

Functional Requirements

Functional Requirement yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️?
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass ✔️
Utilizes unit tests to verify code; all tests for scoreWord pass ✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass ✔️

Overall Feedback

Great work on this project! In this project you’ve taken some interesting logic and worked it into JavaScript syntax. Your code is very clear and readable. Nice work!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements ✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Comment thread src/adagrams.js
drawLetters() {
// Implement this method for wave 1

// added the appropriate number of each letter in an array

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great use of comments to increase readability.

Comment thread src/adagrams.js
// 10 letter words takes precedence
// if there are multiple 10 letter words, use the first one that appears in the array of words
// next is the least letter words
for (const word of highestScoringWords) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider breaking out this logic into its own helper method such as tieBreaker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants