Skip to content

Earth - Beauttie#37

Open
beauttie wants to merge 8 commits into
Ada-C14:masterfrom
beauttie:master
Open

Earth - Beauttie#37
beauttie wants to merge 8 commits into
Ada-C14:masterfrom
beauttie:master

Conversation

@beauttie

Copy link
Copy Markdown

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Creating hash-like objects and iterating through key-value pairs
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? I had to import Lodash to use the sampleSize method (whereas Ruby has many Enumerable methods available for use).
What was something you needed to do independent research on for this project? What did you learn? What instance methods were defined for Array objects in JS
What was a challenge you were able to overcome on this assignment? Understanding the contents of the test file
What has been interesting and positive about learning a new programming language? Seeing how similar foundational concepts are across programming languages and learning a new syntax
What is something to focus on your learnings in JavaScript in the next week? To be able to determine which type of function is appropriate for which setting

Comment thread src/adagrams.js
word: '',
score: maxScore
};
const highestScoringWords = words.filter(word => this.scoreWord(word) === maxScore);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you practiced using filter!

Comment thread src/adagrams.js
}
}

// Fisher-Yates shuffle algorithm

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't end up using this but great that you gave credit here! In addition, assuming you found the code from the web somehere, it can be good to link to the webpage where you found the code.

@jmaddox19

Copy link
Copy Markdown

JS Adagrams

Great work! The code looks great! So glad you are getting so comfortable with JS already!!

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. ✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. ✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures ✔️

Functional Requirements

Functional Requirement yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass ✔️
Utilizes unit tests to verify code; all tests for scoreWord pass ✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants