Earth - Beauttie#37
Open
beauttie wants to merge 8 commits into
Open
Conversation
jmaddox19
reviewed
Dec 17, 2020
| word: '', | ||
| score: maxScore | ||
| }; | ||
| const highestScoringWords = words.filter(word => this.scoreWord(word) === maxScore); |
| } | ||
| } | ||
|
|
||
| // Fisher-Yates shuffle algorithm |
There was a problem hiding this comment.
I know you didn't end up using this but great that you gave credit here! In addition, assuming you found the code from the web somehere, it can be good to link to the webpage where you found the code.
JS AdagramsGreat work! The code looks great! So glad you are getting so comfortable with JS already!! Major Learning Goals/Code Review
Functional Requirements
Overall Feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignment Submission: JS Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection