Stacy's JS Adagrams vanilla fiah

[StacyLundquist]

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?	Finding the handy dandy underscore addition allowed me to use some of the built-in helper methods that were so ...helpful with Ruby, with JS.
Did you need to use different strategies to find information online about JavaScript than you would for Ruby?	Yes, it seemed like a lot of the JS was more advanced or just harder for me to understand. It was easier for me to search for a Ruby function with 'to javascript' at the end.
What was something you needed to do independent research on for this project? What did you learn?	I think the underscore.js counts here? I need to do more research about classes; I attempted it, but was unsuccessful.
What was a challenge you were able to overcome on this assignment?	Knowing how to get started. I struggle with analysis paralysis and often don't know how to start projects. This time I had a plan and jumped right in! I was wrong, but it got the code juices flowing until someone could help me.
What has been interesting and positive about learning a new programming language?	It's fun to see the similarities and differences!
What is something to focus on your learnings in JavaScript in the next week?	Classes, closures, and arrow functions!

[beccaelenzil]

JS Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var.	✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase.	✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures	✔️

Functional Requirements

Functional Requirement	yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass	✔️
Utilizes unit tests to verify code; all tests for scoreWord pass	✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass	✔️

Overall Feedback

Great work on this project! In this project you’ve taken some interesting logic and worked it into JavaScript syntax. Your code is very clear and readable. Nice work!

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 3+ in Functional Requirements	✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever	✅
Descriptive/Readable	✅
Concise	✅
Logical/Organized	✅

[beccaelenzil]

As an arrow function, this would look like this:

Suggested change

	const addLetters = function (letters, frequency) {
	letters.forEach(function (letter) {
	for (let i = 0; i < frequency; i++) {
	letterPool.push(letter);
	}
	})
	const addLetters = (letters, frequency) => {
	letters.forEach(function (letter) {
	for (let i = 0; i < frequency; i++) {
	letterPool.push(letter);
	}
	})

[beccaelenzil]

This is a clever little helper function and a creative way to dynamically fill the letterPool.

[beccaelenzil]

Nice use of a ternary

[beccaelenzil]

Consider moving valid = false to create more consistency with your syntax and increase readability.

[beccaelenzil]

Nice, clean logic! Consider breaking this out into it's own helper function called tieBreaker.