Earth - Kal

[kashenafi]

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?	I was able to associate the "hash" we used in our Ruby Adagrams with the "object" in Javascript. The pattern of using variables felt the same, with the addition of the "let" and "const".
Did you need to use different strategies to find information online about JavaScript than you would for Ruby?	Tried to stick to the official MDN docs as much as I could.
What was something you needed to do independent research on for this project? What did you learn?	Struggles with for...of vs for...in loop, which required quite a bit of debugging.
What was a challenge you were able to overcome on this assignment?	Seeing how many concepts apply to many different syntaxes.
What has been interesting and positive about learning a new programming language?	Getting comfortable with living in what feels like a bracket jungle.
What is something to focus on your learnings in JavaScript in the next week?	Learning more about how tests work.

[dHelmgren]

JS Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var.	✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase.	✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures	✔️

Functional Requirements

Functional Requirement	yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass	✔️
Utilizes unit tests to verify code; all tests for scoreWord pass	✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	5+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard)	0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

[dHelmgren]

In the future, it's bets to remove debugging statements from your submitted code! It makes the test results a lot messier to check!

[dHelmgren]

This is a very Javascript way to build the letter pool. I like it! 😁

[dHelmgren]

do while loops aren't super popular in most js workplaces. You could rewrite this as a vanilla while loop like so:

Suggested change

	do {
	let newIndex = Math.floor(Math.random() * letterPool.length);
	if (!letterHandIndices.includes(newIndex)) {
	letterHandIndices.push(newIndex) }
	}
	while (letterHandIndices.length < 10);
	while (letterHandIndices.length < 10){
	let newIndex = Math.floor(Math.random() * letterPool.length);
	if (!letterHandIndices.includes(newIndex)) {
	letterHandIndices.push(newIndex) }
	}

[dHelmgren]

Dang, super DRY!