Skip to content

Water @ Hanh Solo-JSAdagrams #41

Open
seattlefurby17 wants to merge 7 commits into
Ada-C14:masterfrom
seattlefurby17:master
Open

Water @ Hanh Solo-JSAdagrams #41
seattlefurby17 wants to merge 7 commits into
Ada-C14:masterfrom
seattlefurby17:master

Conversation

@seattlefurby17

Copy link
Copy Markdown

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?
Did you need to use different strategies to find information online about JavaScript than you would for Ruby?
What was something you needed to do independent research on for this project? What did you learn?
What was a challenge you were able to overcome on this assignment?
What has been interesting and positive about learning a new programming language?
What is something to focus on your learnings in JavaScript in the next week?

@kaidamasaki kaidamasaki left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Your code was solid and you made good use of underscore as a library to make your life easier!

PS: Please do the reflection questions in the future. 😃

JS Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. ✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. ✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures ✔️

Functional Requirements

Functional Requirement yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass ✔️
Utilizes unit tests to verify code; all tests for scoreWord pass ✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements
Yellow (Approaches Standards) 4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard) 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Comment thread src/adagrams.js
@@ -1,8 +1,204 @@
import _, { result, shuffle } from 'underscore';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underscore, fancy! 🎩

Comment thread src/adagrams.js
@@ -1,8 +1,204 @@
import _, { result, shuffle } from 'underscore';

const printValue = (value, letter) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be called something like repeatLetter instead of printLetter (since it doesn't print anything out).

Comment thread src/adagrams.js
value += 10;
break;
// default:
// alert (`Your word contains ${char} an invalid character. `);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably meant throw here instead of alert:

Suggested change
// alert (`Your word contains ${char} an invalid character. `);
// throw(`Your word contains ${char} an invalid character. `);

throw is the JS version of raise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants