Skip to content

Maha - Earth#53

Open
Maha-ElMais wants to merge 1 commit into
Ada-C14:masterfrom
Maha-ElMais:master
Open

Maha - Earth#53
Maha-ElMais wants to merge 1 commit into
Ada-C14:masterfrom
Maha-ElMais:master

Conversation

@Maha-ElMais

Copy link
Copy Markdown

Assignment Submission: JS Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt Response
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? iterating through a data structure
Did you need to use different strategies to find information online about JavaScript than you would for Ruby? sometimes I I would get web browser specific implementation or code inside html . MDN is reliable .
What was something you needed to do independent research on for this project? What did you learn? I learned more about the package.json file and the dependencies within in and how they have to be updated in order to implement certain functionality.
What was a challenge you were able to overcome on this assignment? I am still getting used to how to properly write a function as we were introduced to different ways and it is still sinking in. The shortcuts can be confusing.
What has been interesting and positive about learning a new programming language? It feels good to have the foundation of loops and function and function calling and seeing how it is implemented differently in a new language.
What is something to focus on your learnings in JavaScript in the next week? working on writing out functions inside of classes

@CheezItMan CheezItMan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses variables, and only uses const and let variables. The program prefers const variables. The program never uses var. ✔️
Practices best-practices in JavaScript syntax. There are semi-colons at the end of most lines that need semi-colons. Variables and functions are named with camelCase. ✔️
Correctly creates and calls functions within an object with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ⚠️ Only 1 commit!! Gah! And the commit message says, "wave 1 through 4" 😾, you should have small, granular commits and the commit messages should describe the functionality you added, not the waves. You need to git better here!
Utilizes unit tests to verify code; tests can run using the command $ npm test test/adagrams.test.js and we see test successes and/or failures ✔️

Functional Requirements

Functional Requirement yes/no
For the drawLetters function, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for drawLetters and usesAvailableLetters pass ✔️
Utilizes unit tests to verify code; all tests for scoreWord pass ✔️
Utilizes unit tests to verify code; all tests for highestScoreFrom pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 5+ in Code Review && 3+ in Functional Requirements 💚

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Summary

Well done Maha, you hit the learning goals here. Nice work. Just improve on making more commits and with more meaningful commit messages.

Comment thread src/adagrams.js
@@ -1,8 +1,73 @@
import _ from 'lodash';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh Loadash! 😲

Comment thread src/adagrams.js
};

const Adagrams = {
drawLetters() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/adagrams.js
},

//wave 2
usesAvailableLetters: function(input, lettersInHand) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/adagrams.js
},

//wave 3
scoreWord: function(word) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good use of the JS object as a hash!

Comment thread src/adagrams.js
},

// wave 4
highestScoreFrom: function(words) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants