Kareha & Iris

[iris-lux]

Assignment Submission: Video Store API

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Reflection

Prompt	Response
Explain how you came up with the initial design of your ERD, based on the seed data and reading through the API endpoints	We used the seed data to tell us what columns should be in our models, and decided our relationships by looking at the waves and inferring that rentals should be in-between videos and customers, with a one-to-many-relationship w/both.
What would be the Big-O time complexity of your /customers & /videos endpoints? What does the time complexity depend on? Explain your reasoning.	The O(n) would be O(nlogn) b/c we used .order, which sorts the array of items.
What is the Big-O time complexity of the POST /rentals/check-in endpoint? What does the time complexity depend on? Explain your reasoning.	The time complexity would be O(n) because we are performing a search on an ordered set of ids in order to find the proper Rental.
Describe a specific set of positive and negative test cases you implemented for a model.	For Video we tested that a video object would be valid if it has an available_inventory above 0, and invalid if it was below 0.
Describe a specific set of positive and negative test cases you implemented for a controller.	We checked to see if VideosController could get a specific Video with show, and made sure it would return a 404 if it could not find that Video.
Broadly, describe how an API should respond when it handles a request with invalid/erroneous parameters.	IT should either respond with bad_request or not_found.
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	decrease_video_count for Customer, we chose to wrap that in a method b/c its business logic.

[dHelmgren]

Video Store API

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Practices git with at least 10 small commits and meaningful commit messages	✔️
Understands the importance of how APIs handle invalid/erroneous data in their reflection questions	✔️
Practices Rails best practices and well-designed separation, and encapsulates business logic around check-out and check-in in models	✔️
Uses controller tests to ensure quality code for every route, and checks for response status and content, with positive cases and negative cases
Uses controller tests to ensure correctness for check out and check in requirement, and that checked out counts and inventories appropriately change

Functional Requirements

Functional Requirement	yes/no
All provided smoke tests for Wave 1 pass	✔️
All provided smoke tests for Wave 2 pass	✔️

Overall Feedback

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	3+ in Code Review && 2 in Functional Requirements	✔️
Yellow (Approaches Standards)	2+ in Code Review && 1+ in Functional Requirements, or the instructor judges that this project needs special attention
Red (Not at Standard)	0-1 in Code Review or 0 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention