binary search trees #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 4, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Raquel, you hit the learning goals here. Well done. I left a few minor comments, but this is a strong submission.
| self.right = None | ||
|
|
||
|
|
||
| def height(self): |
There was a problem hiding this comment.
Interesting putting this on the TreeNode class.
Comment on lines
+91
to
+93
| # Time Complexity: O(n) | ||
| # Space Complexity:O(n) | ||
| def preorder_helper(self, current, traversal_list): |
Comment on lines
+117
to
120
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
|
|
||
| # Time Complexity: | ||
| # Space Complexity: | ||
| def postorder(self): |
Comment on lines
+75
to
+77
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def inorder_helper(self, current, traversal_list): |
Comment on lines
+26
to
+29
| # Time Complexity: O(log N) | ||
| # Space Complexity: O(1) | ||
|
|
||
| def add_helper(self, current_node, key, value): |
There was a problem hiding this comment.
The space complexity is O(log n) if the tree is balanced due to the recursive call stack.
Comment on lines
+58
to
60
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find(self, key): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOOF! I am struggling with trees! Slowly making some sense but maybe I can ask you about post order, I strugged with figuring out where to put the append....