Skip to content

Algorithms-Python#29

Open
ropeeps wants to merge 1 commit into
Ada-C16:masterfrom
ropeeps:master
Open

Algorithms-Python#29
ropeeps wants to merge 1 commit into
Ada-C16:masterfrom
ropeeps:master

Conversation

@ropeeps

@ropeeps ropeeps commented Jun 23, 2022

Copy link
Copy Markdown

No description provided.

@kyra-patton kyra-patton left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ro, I'm marking this project as a yellow since time and space complexity are missing and that's something we'd really like to think about with dynamic programming. A yellow is a passing score so resubmission is not required, but you are free to resubmit with the time and space complexity filled out for a green score. Let me know what questions you have

🟡

Comment thread lib/max_subarray.py
@@ -7,6 +7,16 @@ def max_sub_array(nums):
"""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Implementations looks great, but what about time and space complexity?

Comment thread lib/newman_conway.py
Comment on lines 7 to 8
Time Complexity: ?
Space Complexity: ?

@kyra-patton kyra-patton Jun 27, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Implementation looks mostly good again here, but what about time and space complexity?

Comment thread lib/newman_conway.py
current_list.append(current_list[current_list[count - 1]] + current_list[count - current_list[count - 1]])
count += 1

return [str(item) for item in current_list]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 To pass the tests, you want to return the newman conway numbers as a string (ex. "0 1 1") instead of a list of strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants