Pine - Victoria Duke#79
Open
VictoriaDuke wants to merge 12 commits into
Open
Conversation
CheezItMan
reviewed
Oct 2, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
I like the small regular commits you made with git as you went through the project. Very meaningful commit messages as well.
Nice work Victoria, you hit the learning goals here. All the functions are readable and work well. Well done.
| pass | ||
| from swap_meet.item import Item | ||
|
|
||
| class Clothing(Item): |
| pass | ||
| from swap_meet.item import Item | ||
|
|
||
| class Decor(Item): |
| pass | ||
| from swap_meet.item import Item | ||
|
|
||
| class Electronics(Item): |
| @@ -1,2 +1,24 @@ | |||
| class Item: | |||
|
|
||
| class Vendor: | ||
| pass | ||
| def __init__(self, inventory=None): |
| self.inventory.remove(item) | ||
| return item | ||
|
|
||
| def get_by_category(self, category=""): |
| items.append(item) | ||
| return items | ||
|
|
||
| def swap_items(self, their_vendor, my_item, their_item): |
| their_vendor.add(my_item) | ||
| return True | ||
|
|
||
| def swap_first_item(self, their_vendor): |
| their_first_item = their_vendor.inventory[0] | ||
| return self.swap_items(their_vendor, my_first_item, their_first_item) | ||
|
|
||
| def get_best_by_category(self, category): |
Author
There was a problem hiding this comment.
Oh I meant to! I think I got distracted by a different part and didn't come back to this.
| best_item = item | ||
| return best_item | ||
|
|
||
| def swap_best_by_category(self, other, my_priority, their_priority): |
There was a problem hiding this comment.
👍 Good reuse of get_best_by_category and swap_items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.