Cedar - Maria O.#97
Open
mobregong wants to merge 2 commits into
Open
Conversation
…d and remove methods
… get_by_category method to Vendor
Comment on lines
+12
to
+16
| if item in self.inventory: | ||
| updated_inventory = self.inventory.remove(item) | ||
| else: | ||
| item = False | ||
| return item |
There was a problem hiding this comment.
Consider refactoring to first check if item is not available. This design is called a guard clause, and can be a nice pattern to follow to enhance readability.
Suggested change
| if item in self.inventory: | |
| updated_inventory = self.inventory.remove(item) | |
| else: | |
| item = False | |
| return item | |
| if item not in self.inventory: | |
| return False | |
| updated_inventory = self.inventory.remove(item) | |
| return item |
|
|
||
| def get_by_category(self, category): | ||
| items = [] | ||
| # [items.append(item) for item in self.inventory if item.category == category] |
There was a problem hiding this comment.
This syntax for a list comprehension will function the same as your classic for loop.
Suggested change
| # [items.append(item) for item in self.inventory if item.category == category] | |
| # items = [item in self.inventory if item.category == category] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.