Zoisite Say R. & Izzy B.#18
Open
LRyder17 wants to merge 27 commits into
Open
Conversation
kelsey-steven-ada
left a comment
kelsey-steven-ada
left a comment
There was a problem hiding this comment.
Great work on waves 1 and 2 for Solar System, Say & Izzy! It looks like you've got a handle on creating a blueprint, registering it with your Flask app, and writing routes. I like the code refactors so that the routes can stay short and sweet!
Comment on lines
+30
to
+33
| result_list = [] | ||
|
|
||
| for planet in planets: | ||
| result_list.append(planet.planet_to_dict()) |
There was a problem hiding this comment.
This would be a good candidate for a list comprehension, what could that look like?
Comment on lines
+49
to
+52
| @planets_bp.route("/<id>", methods=["GET"]) | ||
| def handle_planet(id): | ||
| planet = validate_planet(id) | ||
| return planet.planet_to_dict() |
There was a problem hiding this comment.
It's not a rule and the code still executes just fine, but usually we'd see all the routes grouped together and all the helpers methods grouped together in a file.
added new pytest for empty database
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.