<Pipes>-<Roxanne Agerone>-<Word-Guess> #11
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,255 @@ | ||
| require 'artii' | ||
| require 'colorize' | ||
|
|
||
| class Hangman | ||
| attr_accessor :guesses, :word, :hidden_word, :wrongs | ||
|
|
||
| def initialize | ||
| @guesses = [] | ||
| @word = "" #pick word random from dictionary | ||
| @hidden_word = [] | ||
| @wrongs = 0 | ||
| @fails = 0 | ||
| end | ||
|
|
||
| def make_hidden_word | ||
| @word.length.times do @hidden_word << "____ " | ||
| end | ||
|
|
||
| end | ||
|
|
||
| def choose_word(dictionary) | ||
| @word = dictionary.sample.upcase | ||
| end | ||
|
|
||
| def replace_hidden_with_letter(letter) | ||
| word_index =(0 ... @word.length).find_all {|i| @word[i,1] == letter} | ||
| num_letters = word_index.length | ||
|
|
||
| num_letters.times do |this| | ||
| @hidden_word[word_index[this]] = letter | ||
| end | ||
| end | ||
|
|
||
|
|
||
| def letter_included(guess) | ||
| if @word.include?(guess) | ||
| puts "Good Guess" | ||
| # add letter to hidden_word | ||
| replace_hidden_with_letter(guess) | ||
| ################# | ||
| @hidden_word | ||
| else # ascii minus something | ||
| @fails += 1 | ||
| end | ||
| end # End letter_included | ||
|
|
||
|
|
||
| def pick_a_letter | ||
|
|
||
| while @word.split("") != @hidden_word | ||
|
There was a problem hiding this comment. I like that However, this method ends up being pretty big and complex, even if you don't count the ASCII art. Would it be possible to break it up further? For example, you could have a |
||
|
|
||
| puts "pick a letter" | ||
| letter_guess = gets.chomp.capitalize | ||
|
|
||
| case | ||
| when !!(letter_guess =~ /[A-Z]/) && !@guesses.include?(letter_guess) | ||
| @guesses << letter_guess | ||
|
There was a problem hiding this comment. I'm curious why you choose a |
||
| letter_included(letter_guess) | ||
|
|
||
| case | ||
| when @word.split("") == @hidden_word | ||
| win = Artii::Base.new | ||
| puts win.asciify('Winner Winner').colorize(:magenta) | ||
| puts win.asciify(@word).colorize(:cyan) | ||
| when @fails == 1 | ||
| puts " one wrong | ||
| o8%8888, | ||
|
There was a problem hiding this comment. I like your ascii art, but having all this text in the middle of your program makes it hard to read and to work with. Would it be possible to move this data to a separate file, perhaps something like |
||
| o88%8888888. | ||
| 8'- -:8888b | ||
| 8' 8888 | ||
| d8.-=. ,==-.:888b | ||
| >8 `~` :`~' d8888 | ||
| 88 ,88888 | ||
| 88b. `-~ ':88888 | ||
| 888b ~==~ .:88888 | ||
| 88888o--:':::8888 | ||
| `88888| :::' 8888b | ||
| 8888^^' 8888b | ||
| d888 ,%888b. | ||
| d88% %%%8--'-. | ||
| /88:.__ , _%-' --- - | ||
| '''::===..-' = --." | ||
| #ascii 1 | ||
| when @fails == 2 | ||
| #ascii 2 | ||
| puts " o8%8Two, o8Wrong, | ||
| o88%8888888. o88%8888888. | ||
| 8'- -:8888b 8'- -:8888b | ||
| 8' 8888 8' 8888 | ||
| d8.-=. ,==-.:888b d8.-=. ,==-.:888b | ||
| >8 `~` :`~' d8888 >8 `=` :`=' d8888 | ||
| 88 ,88888 88 ,88888 | ||
| 88b. `-~ ':88888 88b` `-- ':88888 | ||
| 888b ~==~ .:88888 888b -==- .:88888 | ||
| 88888o--:':::8888 88888o--:':::8888 | ||
| `88888| :::' 8888b `88888| :::' 8888b | ||
| 8888^^' 8888b 8888^^' 8888b | ||
| d888 ,%888b. d888 ,%888b. | ||
| d88% %%%8--'-. d88% %%%8--'-. | ||
| /88:.__ , _%-' --- - /88:.__ , _%-' --- - | ||
| '''::===..-' = --. ` '''::===..-' = --. `".colorize(:cyan) | ||
| when @fails == 3 | ||
| #ascii 3 | ||
| puts " | ||
| ____ | ||
| o8%8888, | ||
| o88%8888888. | ||
| 8'- -:8888b | ||
| 8' 8888 | ||
| d8.-=. ,==-.:888b | ||
| >8 `~` :`~' d8888 | ||
| 88 ,88888 | ||
| 88b. `-~ ':88888 | ||
| 888b v=v~ .:88888 | ||
| 88888o--:':::8888 | ||
| `88888| :::' 8888b | ||
| 8888^^' 8888b | ||
| d888 ,%888b. | ||
| d88% %%%8--'-. | ||
| /88:.__ , _%-' --- - | ||
| '''::===..-' = --. ` | ||
|
|
||
|
|
||
| ____ .------. | ||
| o8%8888, / \ | ||
| o88%8888888. .' Three `. | ||
| ' 8'- -:8888b _______|___Wrong_____| | ||
| : 8' 8888 8 8888 | ||
| ` ' d8.-=. ,==-.:888b d8.-=. ,==-.:888b | ||
| ` >8 `~` :`~' d8888 >8 `~` :`~' d8888 | ||
| `:: 88 ,88888 88 ,88888 | ||
| `' 88b. `-~ ':88888 88b. `-~ ':88888 | ||
| `eeeee ==~ .:88888 888b ~==~ .:88888 | ||
| 88888o--:':::8888 88888o--:':::8888 | ||
| `88888| :::' 8888b `88888| :::' 8888b | ||
| 8888^^' 8888b 8888^^' 8888b | ||
| d888 ,%888b. d888 ,%888b. | ||
| d88% %%%8--'-. d88% %%%8--'-. | ||
| /88:.__ , _%-' --- - /88:.__ , _%-' --- - | ||
| '''::===..-' = --. ` '''::===..-' = --. ` | ||
| ".colorize(:green) | ||
|
|
||
| when @fails == 4 | ||
| # ascii 4 | ||
| puts " ____ ____ | ||
| o8%8888, o8%8888, | ||
| o88%8888888. o88%8888888. | ||
| 8'- -:8888b 8'- -:8888b | ||
| 8' 8888 8' 8888 | ||
| d8.-=. ,==-.:888b d8.-=. ,==-.:888b | ||
| >8 `~` :`~' d8888 >8 `=` :`=' d8888 | ||
| 88 ,88888 88 ,88888 | ||
| 88b. `-~ ':88888 88b` `-- ':88888 | ||
| 888b ~==~ .:88888 888b -==- .:88888 | ||
| 88888o--:':::8888 88888o--:':::8888 | ||
| `88888| :::' 8888b `88888| :::' 8888b | ||
| 8888^^' 8888b 8888^^' 8888b | ||
| d888 ,%888b. d888 ,%888b. | ||
| d88% %%%8--'-. d88% %%%8--'-. | ||
| /88:.__ , _%-' --- - /88:.__ , _%-' --- - | ||
| '''::===..-' = --. ` '''::===..-' = --. ` | ||
| Four Wrong | ||
|
|
||
| ____ ____ | ||
| o8%8888, o8%8888, | ||
| o88%8888888. o88%8888888. | ||
| 8'- -:8888b 8'- -:8888b | ||
| 8' 8888 8' 8888 | ||
| d8.-=. ,==-.:888b d8.-=. ,==-.:888b | ||
| >8`88P 88P' d8888 >8 `~` :`~' d8888 | ||
| 88 ,88888 88 ,88888 | ||
| 88b. `-~ ':88888 88b. `-~ ':88888 | ||
| 888b ~==~ .:88888 888b .==. .:88888 | ||
| 88888o--:':::8888 88888o--:':::8888 | ||
| `88888| :::' 8888b `88888| :::' 8888b | ||
| 8888^^' 8888b 8888^^' 8888b | ||
| d888 ,%888b. d888 ,%888b. | ||
| d88% %%%8--'-. d88% %%%8--'-. | ||
| /88:.__ , _%-' --- - /88:.__ , _%-' --- - | ||
| '''::===..-' = --. ` '''::===..-' = --. `".colorize(:blue) | ||
| when @fails == 5 | ||
| # ascii 5 | ||
| puts " _______ | ||
| _,,ad8888888888bba,_ | ||
| ,ad88888I888888888888888ba, | ||
| ,88888888I88888888888888888888a, | ||
| ,d888888888I8888888888888888888888b, | ||
| d8888PP YY88888888888888888888b, | ||
| ,d88 __,,--------,,,,.;ZZZY8888888888888, | ||
| ,8IIl ;;l ZZZIII8888888888, | ||
| ,I88l;' ;lZZZZZ888III8888888, | ||
| ,II88Zl;. ;llZZZZZ888888I888888, | ||
| ,II888Zl;. .;;;;;lllZZZ888888I8888b | ||
| ,II8888Z;; `;;;;;''llZZ8888888I8888, | ||
| II88888Z;' .;lZZZ8888888I888b | ||
| II88888Z; _,aaa, .,aaaaa,__.l;llZZZ88888888I888 | ||
| II88888IZZZZZZZZZ, .ZZZZZZZZZZZZZZ;llZZ88888888I888, | ||
| II88888IZZ<'(@@>Z| |ZZZ<'(@@>ZZZZ;;llZZ888888888I88I | ||
| ,II88888; ` ;| |ZZ; ` ;;llZ8888888888I888 | ||
| II888888l `;; .;llZZ8888888888I888, | ||
| ,II888888Z; ;;; .;;llZZZ8888888888I888I | ||
| III888888Zl; .., `;; ,;;lllZZZ88888888888I888 | ||
| II88888888Z;;...;(_ _) ,;;;llZZZZ88888888888I888, | ||
| II88888888Zl;;;;;' `--'Z;. .,;;;;llZZZZ88888888888I888b | ||
| ]I888888888Z;;;;' ;llllll;..;;;lllZZZZ88888888888I8888, | ||
| II888888888Zl.;; Y88bd888P ;;,..;lllZZZZZ88888888888I8888I | ||
| II8888888888Zl;.; `PPP ;;;,..;lllZZZZZZZ88888888888I88888 | ||
| II888888888888Zl;;. `;;;l;;;;lllZZZZZZZZW88888888888I88888 | ||
| `II8888888888888Zl;. ,;;lllZZZZZZZZWMZ88888888888I88888 | ||
| II8888888888888888ZbaalllZZZZZZZZZWWMZZZ8888888888I888888, | ||
| `II88888888888888888b WWZZZZZWWWMMZZZZZZI888888888I888888b | ||
| `II88888888888888888;ZZMMMMMMZZZZZZZZllI888888888I8888888 | ||
| `II8888888888888888 `;lZZZZZZZZZZZlllll888888888I8888888, | ||
| II8888888888888888, `;lllZZZZllllll;;.Y88888888I8888888b, | ||
| ,II8888888888888888b .;;lllllll;;;.;..88888888I88888888b, | ||
| II888888888888888PZI;. .`;;;.;;;..; ...88888888I8888888888, | ||
| II888888888888PZ;;';;. ;. .;. .;. .. Y8888888I88888888888b, | ||
| ,II888888888PZ;;' `8888888I8888888888888b, | ||
| II888888888' 888888I8888888888888888b | ||
| ,II888888888 ,888888I88888888888888888 | ||
| ,d88888888888 d888888I8888888888ZZZZZZZ | ||
| ,ad888888888888I 8888888I8888ZZZZZZZZZZZZZ | ||
| ,d888888888888888' 888888IZZZZZZZZZZZZZZZZZZ | ||
| ,d888888888888P'8P' Y888ZZZZZZZZZZZZZZZZZZZZZ | ||
| ,8888888888888, ,ZZZZZZZZZZZZZZZZZZZZZZZZ | ||
| d888888888888888, ,ZZZZZZZZZZZZZZZZZZZZZZZZZZZ | ||
| 888888888888888888a, _ ,ZZZZZZZZZZZZZZZZZZZZ888888888 | ||
| 888888888888888888888ba,_d' ,ZZZZZZZZZZZZZZZZZ88888888888888 | ||
| 8888888888888888888888888888bbbaaa,,,______,ZZZZZZZZZZZZZZZ888888888888888888 | ||
| 88888888888888888888888888888888888888888ZZZZZZZZZZZZZZZ888888888888888888888 | ||
| 8888888888888888888888888888888888888888ZZZZZZZZZZZZZZ88888888888888888888888 | ||
| 888888888888888888888888888888888888888ZZZZZZZZZZZZZZ888888888888888888888888 | ||
| 8888888888888888888888888888888888888ZZZZZZZZZZZZZZ88888888888888888888888888 | ||
| 88888888888888888888888888888888888ZZZZZZZZZZZZZZ8888888888888888888888888888 | ||
| 8888888888888888888888888888888888ZZZZZZZZZZZZZZ88888888888888888888888888888 | ||
| 88888888888888888888888888888888ZZZZZZZZZZZZZZ8888888888888888888888888888888 | ||
| 8888888888888888888888888888888ZZZZZZZZZZZZZZ88888888888888888888888888888888 | ||
| This is your last chance".colorize(:magenta) | ||
| when @fails == 6 | ||
| lose = Artii::Base.new | ||
| puts lose.asciify('Sorry, You Lose').colorize(:red) | ||
|
|
||
| exit | ||
| else #no fails yet | ||
| end | ||
| puts "#{hidden_word}" | ||
| else | ||
| puts "No, pick another letter." | ||
| end | ||
| # guesses << pick_a_letter | ||
| # letter_included(letter_guess) | ||
| end | ||
| end | ||
|
|
||
| end # End of Hangman | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| require 'colorize' | ||
| require './hangman' | ||
| #one class, methods | ||
|
|
||
|
|
||
| dictionary = ["pizza", "pasta", "tacos", "bologna", "salad", "popcorn", "pipes", "bubblegum"] | ||
|
|
||
| puts "Let's play a game!" | ||
|
|
||
|
|
||
| my_hangman = Hangman.new | ||
| my_hangman.choose_word(dictionary) | ||
| my_hangman.make_hidden_word | ||
| my_hangman.pick_a_letter | ||
| my_hangman.letter_included |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you've made this its own method. However, the way your code is currently structured it's possible to create an instance of
Hangmanwithout callingchoose_word, in which case none of the rest of your code would work.A cleaner approach might be to call
choose_worddirectly frominitialize, so that it's guaranteed to always happen. This would make your code just a little bit harder to use incorrectly.