Skip to content

Tanja Scrabble -- Stroble -- Carrots#20

Open
misstonbon wants to merge 6 commits into
Ada-C8:masterfrom
misstonbon:master
Open

Tanja Scrabble -- Stroble -- Carrots#20
misstonbon wants to merge 6 commits into
Ada-C8:masterfrom
misstonbon:master

Conversation

@misstonbon

@misstonbon misstonbon commented Nov 17, 2017

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? A lot of how I thought about my code is trying to translate Ruby Scrabble code into JS, since the most important thing to me was to learn the JS syntax.
What was a challenge you were able to overcome on this assignment? I had to look up everything. JS just doesn't come with much built in "magic". For example, I tried using Math.max to calculate highest scored word, but I couldn't figure it out so I worked around that approach in the end. Or maybe it does, but I just don't know enough JS to be able to tell ?
What is your favorite thing about learning a new programming language? Old problems become new and fresh again and they help solidify existing knowledge and perhaps even improve it.
What is your least favorite thing about learning a new programming language? I am a functional programming early adopter, so solving problems "the long way" is always a challenge for me. Also, eslint is very distracting (I am visual). I had it disabled the entire time, which is probably not ok. I like that you can assign a function to a variable. That is super cool.
Do you have any recommendations on how we could improve this project for the next cohort? If you believe prototypes are important, I'd like to see more emphasis on that.

@CheezItMan

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene decent number of commits
Comprehension questions Check, there is a Math.max function. We do think prototypes are important, but classes provide an alternative way to write the code.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check, naming a variable _totalScore is against the AirBNB rules
Has highestScoringWord and highestWordScore functions Check
Overall Overall well done. I would turn on the linter near the end to clean up your code, you do have some minor things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants