Skip to content

scrabble - angela - pipes#26

Open
awilson2017 wants to merge 12 commits into
Ada-C8:masterfrom
awilson2017:master
Open

scrabble - angela - pipes#26
awilson2017 wants to merge 12 commits into
Ada-C8:masterfrom
awilson2017:master

Conversation

@awilson2017

@awilson2017 awilson2017 commented Nov 17, 2017

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? the logic of making the player class' highestwordscore and highest score word funx.
What was a challenge you were able to overcome on this assignment? syntax differences between ruby and js like calling a function on the player object and those pesky curly braces for if else statements (many bugs from these)
What is your favorite thing about learning a new programming language? it opens up new possibilities broaden my marketability and also learn computers from a different perspective.
What is your least favorite thing about learning a new programming language? learning the different behaviors of the fundamentals like objects and functions. There was an example that came up today and now I cannot remember it.
Do you have any recommendations on how we could improve this project for the next cohort? I will get back to you.

@PilgrimMemoirs

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Mostly Good - first question was more focused on identifying patterns in the languages themselves, rather than the scrabble project
General
score calculates score, has appropriate params and return value Well Done
highestScoreFrom calculates highest scoring word, has appropriate params and return value Well Done
Player object
Has name and plays properties Well Done
Has play, totalScore, hasWon functions Well done
Has highestScoringWord and highestWordScore functions Well Done - nice work identifying when to reuse functionality, with calling other functions
Overall
Be mindful of semicolons - they're missing in quite a few places. Do you have eslint installed in atom?
Submission meets project expectations, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants