Skip to content

Sara Chandler -- Carets#30

Open
SaraChandler wants to merge 4 commits into
Ada-C8:masterfrom
SaraChandler:master
Open

Sara Chandler -- Carets#30
SaraChandler wants to merge 4 commits into
Ada-C8:masterfrom
SaraChandler:master

Conversation

@SaraChandler

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I thought about how ruby passed data around with methods and used that to figure out my js functions.
What was a challenge you were able to overcome on this assignment? learning to call functions inside other functions was a bit tricky. Also had to think of a different way to reduce an array.
What is your favorite thing about learning a new programming language? I love that it is so much easier to pick up a second language after learning your first language.
What is your least favorite thing about learning a new programming language? Semicolons. And new syntax in general.
Do you have any recommendations on how we could improve this project for the next cohort? I thought it was easy enough to follow.

Comment thread scrabble.js

totalScore() {
let sumScore = 0;
this.plays.forEach((word) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI there is a .reduce function in JavaScript.

Comment thread scrabble.js
@@ -1,14 +1,149 @@

const Scrabble = {
score: function(word) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could also be written:

score(word) {

Comment thread scrabble.js
score = 0;
}

let wordArr = word.split("");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you never reassign wordArr making it a const is a good idea.

@CheezItMan

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene More granular commits would be better.
Comprehension questions Check, there is a reduce function in JavaScript.
General
score calculates score, has appropriate params and return value Check
highestScoreFrom calculates highest scoring word, has appropriate params and return value Check
Player object
Has name and plays properties Check
Has play, totalScore, hasWon functions Check
Has highestScoringWord and highestWordScore functions Check
Overall Nicely done, I would suggest making sure the linter is on and fixing some of the complaints. It will help you turn in better, more concise code. I notice some small issues and left some comments in your code. You hit all the requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants