<pipes><Roxanne Agerone><js scrabble>

[RAgerone]

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?	There are many similarities between JavaScript and Ruby. I was able to use a lot of the if/else logic as well as string and array manipulation.
What was a challenge you were able to overcome on this assignment?	I was able to overcome the throwing of errors. There were several ways that I found upon searching, but I opted for the simplest way. I am still curious about iterating over hashes in Javascript
What is your favorite thing about learning a new programming language?	I enjoy solving new puzzles and finding new ways to use logic.
What is your least favorite thing about learning a new programming language?	My least favorite thing is when I cannot find an answer because I don't know the search terms for the language yet.
In the long run, this increases my overall satisfaction with solving the problem.
Do you have any recommendations on how we could improve this project for the next cohort?	It was perfect. It was not intimidating and the students can find most of the methods for solving the problems in their Ruby knowledge.

[droberts-sea]

JS Scrabble

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	could be better - even on a small project like this, it's important to break work up into discrete chunks
Comprehension questions	yes
General
score calculates score, has appropriate params and return value	yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value	yes
Player object
Has name and plays properties	yes
Has play, totalScore, hasWon functions	yes
Has highestScoringWord and highestWordScore functions	yes
Overall	Good work overall!

[droberts-sea]

You don't need this final empty else{} clause, you can just close the last else if.

[droberts-sea]

Remember that the messages you throw will probably be seen by the user. 'not found' might not give them enough context to figure out what went wrong - something like `invalid letter ${ letter }`.

[droberts-sea]

This if logic is really long! Could you break it up into multiple lines? Something like

if (wordScore > highestScore ||
    (highestScore === wordScore && word.length < highestScoringWord.length && highestScoringWord.length != 7) ||
    (highestScore === wordScore && word.length === 7)) {

would be easier to read.