Kayla Ecker - Caret#44
Open
kaylaecker wants to merge 2 commits into
Open
Conversation
JS ScrabbleWhat We're Looking For
|
CheezItMan
reviewed
Nov 20, 2017
| score: function(word) { | ||
| // TODO: implement score | ||
| } | ||
| score: function(word) { |
There was a problem hiding this comment.
This could be written as:
score(word) {
| } | ||
| score: function(word) { | ||
|
|
||
| let regex = /^[a-zA-Z]+$/; |
There was a problem hiding this comment.
Making variables you never reassign const is a good idea.
| let score = 0; | ||
|
|
||
|
|
||
| for (let i = 0; i < lowercaseWord.length; i++) { |
There was a problem hiding this comment.
This works fine, you can also use reduce to calculate it.
| Scrabble.Player = class { | ||
| constructor(name) { | ||
| if (name === undefined) { | ||
| throw new Error('Invalid - must be a name'); |
There was a problem hiding this comment.
Good work creating an object to throw the error.
| play(word) { | ||
| let regex = /^[a-zA-Z]+$/; | ||
|
|
||
| if (word === undefined || !regex.test(word)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions