Pipes - Tamira and Roxanne - Rideshare-Rails

[tvojnar]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Our entity relationships were that a tip belongs_to a Driver and a Passenger and that a Driver and a Passenger has_many trips.
Describe the role of model validations in your application	We used validations to confirm the presence of all required attributes in the Driver, Passenger, and Trip models. In addition we validated that a rating can have a nil value and must be between 0 and 5.
How did your team break up the work to be done?	We used the Trello board to split up work and this was convenient because Roxanne was gone on Monday and Tuesday. We pair programed when we set up our nested routes since this was new material that we covered this week.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized the backend part of the project because that is the new material we covered this week. We chose not to add either a drop down menu or a star system to add a rating to an unrated trip because we ran out of time.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Better understanding of some of the Rails hidden magic that happens under the hood. We also gained clarity of errors, relationships between tables in the database, and nested routes.
What is your Trello URL?	https://trello.com/b/ebwkSgfi/rideshare-rails
What is the Heroku URL of your deployed application?	https://tamira-roxanne-rideshare.herokuapp.com/

[kariabancroft]

Note that when you add HTML attributes (like classes and IDs), you don't use the same standard spacing between the = that you are used to with Ruby. So it should be class="wrapper" rather than class = "wrapper"

[kariabancroft]

Pulling in all of the trips should happen in the controller (or possibly even the model), but not in the view

[kariabancroft]

It would be better to negate this condition and put the contents in this block rather than having an empty if

[kariabancroft]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Good - you should get in the habit of adding the .DS_Store file to your .gitignore since its a mac file that isn't a part of your project
Answered comprehension questions	Yes
Uses named routes (like _path)	Yes
RESTful routes utilized	Yes - I like the way you used the only for the specific trip routes that needed to be nested. Nitpick on the root route that it should be the first route listed in the file.
Rideshare Rails Specific Content
Table relationships	Schema looks good as do the relationships in the ActiveRecord model files.
Validation rules for Models	Yes - nice job using the presence validations as well as a more in-depth validation for the rating.
Business logic is in the models	Yes - some rating and average logic in there.
Database is seeded from the CSV files	N/A
Trello board is created and utilized in project management	Can you make your Trello board public so I can access & review?
Postgres database is used	Yes
Heroku instance is online	Yes
The app is styled to create an attractive user interface	Lovely styling!
Overall	You did a nice job hitting the major learning goals of this assignment. You came up with a nice final product.