Kimberley Z and Sara F - Pipes - initial pull request

[kimpossible1]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Entities: Trips, Drivers, Passengers. A trip has a passenger and a driver. A driver has one or many trips. A passenger has one or many trips.
Describe the role of model validations in your application	This makes sure a new element does not get added to database without the information required.
How did your team break up the work to be done?	Using Trello. Mostly we tackled items as they became the priority in a logical order.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized basic functionality - having the correct view pages, being able to see the lists from the database and individual elements. Then we prioritized being able to create new, edit, and then delete. After the basics were done, we worked on styling and then deployment. We would have styled it more if given more time.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Kimberley got a bit more comfortable with CSS, and more clarity on how to set up models and migrate. Also, really learned how to use db:reset - solid now. Also learned, about putting code in models and pretty comfortable with that now. Sara learned a lot more about the roles of the controller pages. She also now feels more comfortable with inserting ruby code in erb files, and also understand what she's looking at when looking at models and routes.
What is your Trello URL?	https://trello.com/b/cD6WyTzB/rideshare
What is the Heroku URL of your deployed application?	http://tasklist-kimberley-sara.herokuapp.com

[kariabancroft]

You could also use an enumerable method to make this code more succinct.

[kariabancroft]

Nice job using a partial for the errors as well as this form

[kariabancroft]

You'll learn more about view helpers later - but this would be a great place to use one so that you don't have to copy/paste the way to format $ every time you need it in a view

[kariabancroft]

What happens if this update operation fails?

[kariabancroft]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Contributions look good - you should continue to focus on meaningful commit messages. Envision your commit history as a map of how you've written your code that will need to be traced by someone else in the future.
Answered comprehension questions	Looks good
Uses named routes (like _path)	Yes
RESTful routes utilized	Looks good - style nitpick: put the root route at the top of the routes file
Rideshare Rails Specific Content
Table relationships	Schema file and model relationships look good
Validation rules for Models	Nice job using the presence validations - I'd like to see you try some of the other types out in future projects
Business logic is in the models	Yes - totals and averages
Database is seeded from the CSV files	Yes? Probably/possibly?
Trello board is created and utilized in project management	Could you make your Trello board public so I can take a look?
Postgres database is used	Yes
Heroku instance is online	Yes! I really like your theme of "Ride4Change". Awesome!
The app is styled to create an attractive user interface	Yes - I like the way you used the driver and passenger names in the links to their individual show pages.
Overall	Nice job overall hitting the major learning goals of this assignment.

[kimpossible1]

HI Kari, Thanks for the feedback! We did not receive instruction on how to upload files to heroku but our databse was seeded. I've made the Trello board public now. Thanks!! Kimberley

…

On Fri, Oct 13, 2017 at 11:18 AM, Kari Bancroft ***@***.***> wrote: Rideshare-Rails What We're Looking For Feature Feedback *Baseline* Appropriate Git Usage with no extraneous files checked in and both partners contributing Contributions look good - you should continue to focus on meaningful commit messages. Envision your commit history as a map of how you've written your code that will need to be traced by someone else in the future. Answered comprehension questions Looks good Uses named routes (like _path) Yes RESTful routes utilized Looks good - style nitpick: put the root route at the top of the routes file *Rideshare Rails Specific Content* Table relationships Schema file and model relationships look good Validation rules for Models Nice job using the presence validations - I'd like to see you try some of the other types out in future projects Business logic is in the models Yes - totals and averages Database is seeded from the CSV files Yes? Probably/possibly? Trello board is created and utilized in project management Could you make your Trello board public so I can take a look? Postgres database is used Yes Heroku instance is online Yes! I really like your theme of "Ride4Change". Awesome! The app is styled to create an attractive user interface Yes - I like the way you used the driver and passenger names in the links to their individual show pages. *Overall* Nice job overall hitting the major learning goals of this assignment. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYj-_nDAcSfn-fFedq6haZ3nij7eZDUbks5sr6l1gaJpZM4Prawd> .