Skip to content

Isaac & Sara Trello#2

Open
SaraChandler wants to merge 67 commits into
Ada-C8:masterfrom
hisaacdelr:master
Open

Isaac & Sara Trello#2
SaraChandler wants to merge 67 commits into
Ada-C8:masterfrom
hisaacdelr:master

Conversation

@SaraChandler

@SaraChandler SaraChandler commented Oct 2, 2017

Copy link
Copy Markdown

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way A driver has many trips, a passenger has many trips, trip belongs to driver and passengers. Because trips contains ids for driver and passenger, trip will belong to them. Driver and passenger are not related except through trip, of which they can have many of.
Describe the role of model validations in your application Model validations let us sanitize the data being submitted in our forms, and allows us to stop the submission in order to throw errors. We used them to stop a user from submitting an empty form and to make sure they could only submit numbers where appropriate.
How did your team break up the work to be done? We divided the work according to routes and their corresponding views and controller methods. For tasks where we struggled, we reconvened or message each other via Slack and look up syntax/solutions and discuss them together.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? We prioritized correct routing for links and because of time constraints we had to sacrifice fine-tuning the UI’s CSS.
What was one thing that your team collectively gained more clarity on after completing this assignment? How routes work and the controller’s role in directing the application to their correct route.
What is your Trello URL? https://trello.com/b/nCOiZI9G/rideshare
What is the Heroku URL of your deployed application?

@tildeee

tildeee commented Oct 13, 2017

Copy link
Copy Markdown
  • Editing a trip from its detail page doesn't work
  • Didn't keep Trello board up to date
  • Great theme


<%= form_for @trip do |f| %>
<%= f.select :rating, options_for_select((1..5)) %>
<%=f.submit, class: "button"%>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comma creates a syntax error

@tildeee

tildeee commented Oct 13, 2017

Copy link
Copy Markdown

Rideshare-Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing x
Answered comprehension questions x
Uses named routes (like _path) a little unsure about how you're using named paths in your TripsController
RESTful routes utilized x
Rideshare Rails Specific Content
Table relationships x
Validation rules for Models x
Business logic is in the models x
Database is seeded from the CSV files x
Trello board is created and utilized in project management didn't update it
Postgres database is used x
Heroku instance is online
The app is styled to create an attractive user interface spooky
Overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants