Carets -- Laura & Victoria by vsawchuk · Pull Request #20 · Ada-C8/rideshare-rails

vsawchuk · 2017-10-06T23:35:54Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We have a table each for drivers, passengers, and trips. Drivers and passengers have many trips, and trips belong to drivers and passengers. Drivers and passengers can have more than one trip, but each trip can only have one driver and one passenger.
Describe the role of model validations in your application	They prevent improper user input, and ensure presence of all necessary variables. This helps to prevent db errors caused by changes to the controllers.
How did your team break up the work to be done?	We paired on everything!...almost everything. We paired for all the required items, and broke out some smaller optional work at the end.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We didn't finalize all styling or additional driver/rider/trip interaction, but we met all required features.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Validations, rendering partial forms with local variables, and styling.
What is your Trello URL?	https://trello.com/b/9BQclyMP/rideshare
What is the Heroku URL of your deployed application?	https://l-v-rideshare.herokuapp.com/

* Update routes to convention over configuration

…w passenger or driver

…f passenger_index_path

…rips

…to combine styling and db changes

CheezItMan · 2017-10-07T22:05:43Z

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Good number of commits and good participation by both team members.
Answered comprehension questions	Check
Uses named routes (like `_path`)	Check
RESTful routes utilized	Check, nice work with status and using resources.
Rideshare Rails Specific Content
Table relationships	Check Trips related to both Drivers and Passengers.
Validation rules for Models	Check, good messages and validations for presence and score values.
Business logic is in the models	There is No business logic in the models. You should put things like finding an available driver as a method in the Driver class and a method to calculate the average rating in Trips. Do not put that in the controllers.
Database is seeded from the CSV files	Good use of `Rails.root.join`, also good work reseting the ID field sequence in the DB.
Trello board is created and utilized in project management	Check, nice work
Postgres database is used	Check
Heroku instance is online	Check, nicely styled
The app is styled to create an attractive user interface	I like the styling simple and elegant.
Overall	Nice work, you hit all the requirements. As noted, think about putting more business logic in the model files.

CheezItMan

Some in-code comments.

CheezItMan · 2017-10-07T21:58:50Z

+
+  def new
+    driver_id = find_driver()
+    @trip = Trip.new(date: Date.today, cost: rand(100..2000), driver_id: driver_id, passenger_id: params[:passenger_id], rating: nil)


This makes a good place to use strong params.

CheezItMan · 2017-10-07T21:59:21Z

+    @passenger = Passenger.find_by(id: params[:id].to_i)
+    redirect_to passenger_path unless @passenger
+
+    if @passenger.update_attributes passenger_params


Good use of strong params.

CheezItMan · 2017-10-07T21:59:45Z

+    return params.require(:driver).permit(:name, :vin)
+  end
+
+  def rating(trips)


Shouldn't this be in the model.

CheezItMan · 2017-10-07T21:59:55Z

+  end
+
+  def total(trips)
+    return trips.sum {|trip| trip.cost}


Another good thing to move to the model

CheezItMan · 2017-10-07T22:03:29Z

+<section class="user_list">
+  <h1>Drivers</h1>
+  <p>
+    Our drivers are the best. Everyday carry enamel pin vape beard jean shorts artisan. Knausgaard flexitarian wolf keytar affogato, kale chips helvetica subway tile craft beer YOLO cold-pressed cliche. Sustainable +1 ugh, air plant yuccie cold-pressed humblebrag chicharrones seitan chartreuse cray jianbing.


CheezItMan · 2017-10-07T22:04:27Z

+    <p>Please rate your last trip:</p>
+    <%= form_tag(rate_trip_path(id: @needs_rating.id), method: :patch, class: 'rating') do %>
+      <%= label_tag('Rating') %>
+      <div class='rating-labels'>


Good use-case for a div element.

vsawchuk and others added 30 commits October 2, 2017 14:31

Initialize rails app

c40faab

Add Driver, Passenger, and Trip models, migrate db

4cbad56

Database seeded

b23614d

Add Passenger and Rideshare controllers

0a164b3

Display passenger names on route /passengers

fe85e79

Display list of drivers on route /driver/index

cef4b61

* Update routes to convention over configuration

Link to driver detail page from list of drivers

531e1a2

Passenger controller, html.erb pages

aad766c

Added references between trips, driver, passenger

30b2b5d

Display list of trips taken by passenger on details page

719d20b

Added edit and delete for Passenger

a738bd1

Add trip details page, link to passenger details page'

5f8734f

Add link to trip details page to passenger details page

dd313cb

Driver details page added

7adc7d0

Add links to details pages from other details pages

4ddba33

Modify controllers to plural versions of their names

36c1b74

Add ability to create new trip with no rating

18a3e53

Application html setup, light CSS styling, driver edit view added

49c3e77

Passenger can add a rating to a trip without one

6f5ab99

Add edit_trip path

5e97d93

Resolve merge conflict for edit_trip path in routes

099e396

Add functionality to edit a trip rating from the show trip view

2a24db7

Added styling to nav and tables for mobile responsivness

b5e9f68

Shift all tables to adapt to screen size <600px

05b4cdc

Add tandem bike photo to assets

2a001bb

Begin styling nav, header, footer

989aa46

Model validations on Passenger and Driver, print errors for adding ne…

c0df60a

…w passenger or driver

Update passengers controller to redirect to passengers_path instead o…

8d40323

…f passenger_index_path

Styling to Passenger and Driver index pages

f45f609

Footer always at bottom

1554f14

vsawchuk and others added 11 commits October 6, 2017 13:57

add radio buttons to trip rating

2f5d7c5

Add star ratings to passenger page for trip rating

ba74dd4

Change html image tag to rails image_tag

d07a878

remove duplicate tandemshare heading on homepage

cc0ee07

Give drivers a status of online or offline

bc062a6

Passengers can only get a driver that is online

92388d9

Styling to forms, and passenger page

5fbed13

Add status to trips

57c47a0

Update seed files and seed script to include status for drivers and t…

7b14e1a

…rips

Final styling to driver, passenger pages, and index

c0d3915

Merge branch 'master' of https://github.com/vsawchuk/rideshare-rails …

c9a898e

…to combine styling and db changes

CheezItMan reviewed Oct 7, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Carets -- Laura & Victoria#20

Carets -- Laura & Victoria#20
vsawchuk wants to merge 41 commits into
Ada-C8:masterfrom
vsawchuk:master

vsawchuk commented Oct 6, 2017

Uh oh!

CheezItMan commented Oct 7, 2017

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan Oct 7, 2017

Uh oh!

CheezItMan Oct 7, 2017

Uh oh!

CheezItMan Oct 7, 2017

Uh oh!

CheezItMan Oct 7, 2017

Uh oh!

CheezItMan Oct 7, 2017

Uh oh!

CheezItMan Oct 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

vsawchuk commented Oct 6, 2017

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Oct 7, 2017

Rideshare-Rails

What We're Looking For

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Uh oh!

CheezItMan Oct 7, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Oct 7, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Oct 7, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Oct 7, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Oct 7, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Oct 7, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants