Skip to content

Kayla and Canaan Carets#21

Open
kaylaecker wants to merge 38 commits into
Ada-C8:masterfrom
kaylaecker:master
Open

Kayla and Canaan Carets#21
kaylaecker wants to merge 38 commits into
Ada-C8:masterfrom
kaylaecker:master

Conversation

@kaylaecker

Copy link
Copy Markdown

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way Trips has a passenger and a driver, Passenger and Driver both belong to trip, because the data was set up that.
Describe the role of model validations in your application Used validations to ensure a user couldn't leave a name field, vin number, or phone number empty.
How did your team break up the work to be done? We did the set up together, Kayla did passengers, Canaan did drivers, and we finished up together.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline? Prioritized functionality so that the program would do all of the requirements, we did not prioritize styling (although it is lovely)
What was one thing that your team collectively gained more clarity on after completing this assignment? More about foreign keys and relationships between tables in the database.
What is your Trello URL? https://trello.com/b/66Nc7kUw/rideshare
What is the Heroku URL of your deployed application? https://sleepy-inlet-16249.herokuapp.com/trips/home

Kayla Ecker and others added 30 commits October 2, 2017 15:09
@tildeee

tildeee commented Oct 13, 2017

Copy link
Copy Markdown

Rideshare-Rails

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing x
Answered comprehension questions x
Uses named routes (like _path) x
RESTful routes utilized x (didn't use resources, which is fine)
Rideshare Rails Specific Content
Table relationships x
Validation rules for Models x
Business logic is in the models x
Database is seeded from the CSV files x
Trello board is created and utilized in project management add me on dee@adadevelopersacademy.org
Postgres database is used x
Heroku instance is online x
The app is styled to create an attractive user interface x, or die
Overall

@tildeee

tildeee commented Oct 14, 2017

Copy link
Copy Markdown

The following process breaks the site:

  • I make Trip A for Driver A and Passenger A. Trip A does not have cost assigned to it.
  • I view the show page for Driver A

Breaks when trying to call trip.cost_convert because cost is nil.

Comment thread app/models/trip.rb


def cost_convert
"%.2f" % (cost / 100.0)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if cost is nil then this breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants