Carets- Jan and Julia

[julmeier]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Each trip only has one passenger and one driver, according to our model . Both passengers and drivers can have many trips, so we added a reference to our trips table so that the passenger and driver id's were foreign keys. We did this so that the passenger and the driver AR object can access the information from the trips table.
Describe the role of model validations in your application	We used model validation to make sure that specific form fields were required in order for the user to create or modify a new driver, passenger or trip.
How did your team break up the work to be done?	Since Julia was sick in the beginning of the week, Jan took the reins and partnered with Shaunna and Jocelyn to work together to get the project set up, including developing the trello board, setting up the model, etc. Julia focused on the HTML/CSS at the end of the project.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We kept the views very primitive while developing and prioritized implementing the routes, generating and developing the controller, seeding the model. Only when all the logic was complete did we start with the styling. We had to put aside fancy styling in order to meet the deadline!
What was one thing that your team collectively gained more clarity on after completing this assignment?	We've gotten a better grasp on the use and interaction of the MVC paradigm. But we could use some clarity on the separation of concerns of the logic in the controller and model. We know that, based on homework reading, that if there is a question of where code belongs, it likely belongs in the model- but a discussion would still help.
What is your Trello URL?	https://trello.com/b/Ekj4qp5O/rideshare-pairprogramming
What is the Heroku URL of your deployed application?	https://arcane-fortress-54184.herokuapp.com

[CheezItMan]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Good number of commits and both partner contributed.
Answered comprehension questions	Check, we'll do more discussion about where methods for business logic go next week I think.
Uses named routes (like _path)	check,
RESTful routes utilized	Check, except for routes like rating a trip.
Rideshare Rails Specific Content
Table relationships	Check
Validation rules for Models	You have validations for the presence of fields, but you should have validations to limit ratings to specific values and
Business logic is in the models	Great work here putting business logic in the models.
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	It doesn't look like you used the Trello board much. Most things are in the to-do category.
Postgres database is used	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface
Overall	I like how if I delete things like a trip it goes back to the passenger page. The stylings look nice and attractive. I like how you had columns used for lists of passengers and drivers. You hit all the requirement in terms of functionality. Note my comment in your code that you have a bug for when a driver has no trips, the show page will generate an error because they have no trips (divide by 0). Other than that good work!

[CheezItMan]

This method always does integer division to calculate the average. So you can't have a rating of 2.5.

Also what if they have no trips! This will generate an error!

[CheezItMan]

You should have a validation for rating to limit them between 0 and 5 or 1 and 5.

[julmeier]

Hi Chris, Thanks for your review! I have a couple of follow-up questions. Feel free to answer via email or I can follow-up with you to discuss in person next week with Jan. Hope you had a great vacation! - Regarding the "RESTful routes utilized" - how could we change our code to to apply restful routes (like rating a trip)? This principle is still elusive to me. -Do we still need to put validations for the rating, even if we are only providing the user a drop-down menu of choices of integers 1 through 5? Thank you, Julia

…

On Sat, Oct 7, 2017 at 5:18 PM, Chris M ***@***.***> wrote: Rideshare-Rails What We're Looking For Feature Feedback *Baseline* Appropriate Git Usage with no extraneous files checked in and both partners contributing Good number of commits and both partner contributed. Answered comprehension questions Check, we'll do more discussion about where methods for business logic go next week I think. Uses named routes (like _path) check, RESTful routes utilized Check, except for routes like rating a trip. *Rideshare Rails Specific Content* Table relationships Check Validation rules for Models You have validations for the presence of fields, but you should have validations to limit ratings to specific values and Business logic is in the models Great work here putting business logic in the models. Database is seeded from the CSV files Check Trello board is created and utilized in project management It doesn't look like you used the Trello board much. Most things are in the to-do category. Postgres database is used Check Heroku instance is online Check The app is styled to create an attractive user interface *Overall* I like how if I delete things like a trip it goes back to the passenger page. The stylings look nice and attractive. I like how you had columns used for lists of passengers and drivers. You hit all the requirement in terms of functionality. Note my comment in your code that you have a bug for when a driver has no trips, the show page will generate an error because they have no trips (divide by 0). Other than that good work! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUSbfQ3DHhherO3CdoVCChMeHD4KXMF9ks5sqBTkgaJpZM4PxMTO> .

[CheezItMan]

- Regarding the "RESTful routes utilized" - how could we change our code to to apply restful routes (like rating a trip)? This principle is still elusive to me. No since this isn't a generic CRUD operation, you're not going to have a RESTful route. That's ok as long as for the generic Create-Update-Read-Delete operations you're following the pattern.

…

-Do we still need to put validations for the rating, even if we are only providing the user a drop-down menu of choices of integers 1 through 5? Yes, because you might change the UI at some point, like providing a mobile app interface, and want the guarantee of valid data. Also your app could later get input directly from other apps, we'll talk about them when you make web APIs, and the validations are important here. It's really a 2-layer approach, protect data at the UI end, and at the database layer. I hope these answers are helpful. Thanks for the wishes regarding the holiday.

On Sat, Oct 7, 2017 at 11:02 PM, julmeier ***@***.***> wrote: Hi Chris, Thanks for your review! I have a couple of follow-up questions. Feel free to answer via email or I can follow-up with you to discuss in person next week with Jan. Hope you had a great vacation! - Regarding the "RESTful routes utilized" - how could we change our code to to apply restful routes (like rating a trip)? This principle is still elusive to me. -Do we still need to put validations for the rating, even if we are only providing the user a drop-down menu of choices of integers 1 through 5? Thank you, Julia On Sat, Oct 7, 2017 at 5:18 PM, Chris M ***@***.***> wrote: > Rideshare-Rails What We're Looking For > Feature Feedback > *Baseline* > Appropriate Git Usage with no extraneous files checked in and both > partners contributing Good number of commits and both partner contributed. > Answered comprehension questions Check, we'll do more discussion about > where methods for business logic go next week I think. > Uses named routes (like _path) check, > RESTful routes utilized Check, except for routes like rating a trip. > *Rideshare Rails Specific Content* > Table relationships Check > Validation rules for Models You have validations for the presence of > fields, but you should have validations to limit ratings to specific values > and > Business logic is in the models Great work here putting business logic in > the models. > Database is seeded from the CSV files Check > Trello board is created and utilized in project management It doesn't > look like you used the Trello board much. Most things are in the to-do > category. > Postgres database is used Check > Heroku instance is online Check > The app is styled to create an attractive user interface > *Overall* I like how if I delete things like a trip it goes back to the > passenger page. The stylings look nice and attractive. I like how you had > columns used for lists of passengers and drivers. You hit all the > requirement in terms of functionality. Note my comment in your code that > you have a bug for when a driver has no trips, the show page will generate > an error because they have no trips (divide by 0). Other than that good > work! > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#24# issuecomment-334974263>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ AUSbfQ3DHhherO3CdoVCChMeHD4KXMF9ks5sqBTkgaJpZM4PxMTO> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABH3SKm4GyKjCFlWL3k1wtD5M86PKMYJks5sqGVtgaJpZM4PxMTO> .

-- Chris McAnally Ada Developer Academy Instructor Pronouns: He/Him <http://pronoun.is/> Change the world, one line at a time.