Initial rails new app by SRBusiness · Pull Request #7 · Ada-C8/rideshare-rails

SRBusiness · 2017-10-02T22:46:36Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We have three entities: drivers, passengers, trips. Drivers and riders have no direct relationship but are connected via trips. Drivers may have zero or many trips, trips one and only one driver. Riders have zero or many trips, while trips have one and only one rider.
Describe the role of model validations in your application	We did two types of validation, strong params for every controller. Additionally in the models we validated the presence, numerically, and nil validity for a number of values.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	In the beginning we prioritized functionality and then worked on the aesthetics once we had the app functioning. We didn't really have to sacrifice any features to complete the project in the timeline.
What was one thing that your team collectively gained more clarity on after completing this assignment?	Broadly routes, more specifically we have a much stronger understanding of resources and nested routes. In building this app we have a much better conceptual grasp of how the different parts of rails work together.
How did your team break up the work to be done?	We decided to do the main implementation of the models and data seeding together. We used the navigator driver model of pair programming often. When we got further along in the program we split up individual tasks and took advantage of branching.
What is the Heroku URL of your deployed application?	srbeek-rideshare.herokuapp.com
What is your Trello URL?	https://trello.com/b/d1lEfDkW/ride-share

… methods for drivers_controller.rb

Terminal told me to pull so I'm following instructions and merging. -srb

… trips

…lated pages

…l files

…n passenger and driver

srb merge minor changes

… stuff

kariabancroft · 2017-10-12T21:52:34Z

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Yes looks good
Answered comprehension questions	Yes
Uses named routes (like `_path`)	Yes
RESTful routes utilized	Yes - nice job using `only` to ensure you were not creating duplicate routes.
Rideshare Rails Specific Content
Table relationships	Schema and model relationships look good
Validation rules for Models	Yes - nice job using presence and numericality validations
Business logic is in the models	Yes - totals, monetary conversions
Database is seeded from the CSV files	Yes? Probably?
Trello board is created and utilized in project management	Yes - nice job on this
Postgres database is used	Yes
Heroku instance is online	Yes! You even have a favicon!
The app is styled to create an attractive user interface	Yes - you did a really awesome job with the final design. You have created a nice user experience that is easy to navigate and find the information desired.
Overall	You did a really nice job hitting the major learning goals on this assignment. You covered a lot of ground via routes, model methods, view helpers and pagination. Nice job.

kariabancroft · 2017-10-12T21:37:26Z

@@ -0,0 +1,36 @@
+<span class="stars">
+  <% case model


I love the way you used a partial for this. You could utilize a loop that would generate the stars for the number specified and that would really simplify this view.

kariabancroft · 2017-10-12T21:38:10Z

@@ -0,0 +1,21 @@
+<%= form_for @passenger, html: {id: "passenger-form"} do |f| %>


Yes - nice job using a partial for this form.

kariabancroft · 2017-10-12T21:48:28Z

+class ApplicationRecord < ActiveRecord::Base
+  self.abstract_class = true
+
+  def total_money


The only issue with this method here is that it will also apply to the Trip model which probably won't work or be useful.

kariabancroft · 2017-10-12T21:50:04Z

+
+  def average_rating
+    if trips.any? == false
+      return "Nil"


It would be better to return either nil itself or a string describing the type of issue rather than the string of "Nil" which is not meaningful to your users

kariabancroft · 2017-10-12T21:51:41Z

+    length = trips.length
+    total = 0
+
+    trips.each do |trip|


You could also use an enumerable method to pluck out the ratings values that were populated and create an average that way

SRBusiness and others added 30 commits October 2, 2017 15:16

Initial rails new app

961c7ea

Generates riders, drivers, trips controllers

5b0cce2

Adds RESTful routes for all controllers

a6f71b9

updates from rider to passenger controller and routes

329a32d

Added models for driver, passenger, and trip; migrated to DB

0f66274

Added home controller and route

37240b6

Added home index.html.erb file

1036131

Added view folders for drivers, passengers, and trips; also added all…

798c8ff

… methods for drivers_controller.rb

Added relationships in driver, passenger, and trip models

36843a4

Adds a driver show view and a link_to from driver index to show view

ebcac48

Adds vailation logic in models for driver, passenger, trips

8d22714

updates driver index tables

66da931

adds model logic for driver averagerating and total earnings

8a25055

Delete driver link on show driver view

af4927f

adds new partials and views for diver

e20cd9a

Edit driver is functional with errrs and validation

e459b75

Added CSS styles to home#index

94b76d6

Merge branch 'master' of https://github.com/SRBusiness/rideshare-rails

0aab961

Made a sticky footer

5eb602e

Adds a add driver link_to and functioning form

2e8eace

Merge branch 'master' of https://github.com/SRBusiness/rideshare-rails

efdf44c

Terminal told me to pull so I'm following instructions and merging. -srb

added money gem to bundle

6ab8492

Nested routes.rb for trips

a37d61c

Edited trips_controllers and drivers/show.html.erb to show a driver's…

5063a5e

… trips

Improved routes.rb

1a5888e

Added delete and show methods to trips controller and edited trips re…

6cf2a31

…lated pages

Added methods to passengers controller; created needed passengers htm…

f3b494e

…l files

Updates driver controller create function to render if cannot save

4fc2b60

adds fuction for dollar and updates total_earning method

c4ec745

Updates money methods

136e285

SRBusiness and others added 28 commits October 5, 2017 13:48

made a new method in application record model to replace the totals i…

1b23f4f

…n passenger and driver

minor tweeks on total_money method

288f41f

Made sure $ was uniform

c308dc7

removes old totals methods from model

983af02

functioning add new trip

66c2df4

CAN CREATE TRIPS WITH PROPER DB DATA

0c94e55

update ave rating method to deal with nil

d57b1cb

clear white space

dbf44f3

Merge branch 'master' of https://github.com/SRBusiness/rideshare-rails

77dfe5a

srb merge minor changes

Trip edit works, hides rating column if new record, messed with money…

13ce9d0

… stuff

Added CSS styling to drivers and trips pages

e994c7f

Edited some CSS style

751f120

Merge branch 'css_edits'

f474b40

Edited icon for rating in form file

27250ac

update gem file with better_errors, pry, and binding_of_caller

75e2082

Added integer range validations to rating

0f25123

Added tooltip for edit trip view - rating

0b92969

Dry up trips controller, made trip_create method in model

ad61215

add favicon link tag

51d774a

Added a favicon

0bab26d

Removes white space and old comments

541abf2

Adds a partial render for star ratings html

134df43

refactored trip default values method

069105c

Cleaned up CSS to be in one file

30a7aae

add kamanari gem

04a65a5

Adds pagination to driver and passenger view

5ae4a80

Edited pagination CSS/HTML

f832400

Edited font path and location

aa90236

kariabancroft reviewed Oct 12, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Initial rails new app#7

Initial rails new app#7
SRBusiness wants to merge 61 commits into
Ada-C8:masterfrom
SRBusiness:master

SRBusiness commented Oct 2, 2017 •

edited

Loading

Uh oh!

kariabancroft commented Oct 12, 2017

Uh oh!

kariabancroft Oct 12, 2017

Uh oh!

kariabancroft Oct 12, 2017

Uh oh!

kariabancroft Oct 12, 2017

Uh oh!

kariabancroft Oct 12, 2017

Uh oh!

kariabancroft Oct 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,21 @@
		<%= form_for @passenger, html: {id: "passenger-form"} do \|f\| %>

Uh oh!

Conversation

SRBusiness commented Oct 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rideshare-Rails

Comprehension Questions

Uh oh!

kariabancroft commented Oct 12, 2017

Rideshare-Rails

What We're Looking For

Uh oh!

kariabancroft Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

kariabancroft Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

kariabancroft Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

kariabancroft Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

kariabancroft Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SRBusiness commented Oct 2, 2017 •

edited

Loading