Skip to content

Ampers - Maddie Shields#25

Open
madaleines wants to merge 8 commits into
Ada-C9:masterfrom
madaleines:master
Open

Ampers - Maddie Shields#25
madaleines wants to merge 8 commits into
Ada-C9:masterfrom
madaleines:master

Conversation

@madaleines

Copy link
Copy Markdown

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote.
Describe how you approached testing that model method. What edge cases did you come up with?
What are session and flash? What is the difference between them?
Describe a controller filter you wrote.
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application?
Do you have any recommendations on how we could improve this project for the next cohort?

@CheezItMan

Copy link
Copy Markdown

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Very few commits
Comprehension questions MISSING slack me if you answer the comprehension questions and would like me to review them.
General
Rails fundamentals (RESTful routing, use of named paths) Check
Semantic HTML Only a little HTML available for me to look at, but what you have is semantic.
Errors are reported to the user MISING
Business logic lives in the models MISING
Models are thoroughly tested, including relations, validations and any custom logic MISING
Wave 1 - Media
Splash page shows the three media categories Check
Basic CRUD operations on media are present and functional MISING Only show and index are available for works.
Wave 2 - Users and Votes
Users can log in and log out MISING
The ID of the current user is stored in the session MISING
Individual user pages and the user list are present MISING
A user cannot vote for the same media more than once MISING
All media lists are ordered by vote count MISING
Splash page contains a media spotlight MISING
Media pages contain lists of voting users MISING
Wave 3 - Styling
Foundation is used appropriately MISING
Look and feel is similar to the original MISING
Overall This is not close to complete. Slack me or message me when you are closer or if you want to schedule time to sit down and look at this.

Comment thread config/routes.rb
root 'welcomes#index'

resources :works
resources :users, only: [:index, :create, :edit, :show]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need an edit action for users?

Comment thread app/models/work.rb
@@ -0,0 +1,2 @@
class Work < ApplicationRecord

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validations? Methods??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants