Skip to content

Ampers Abinnet#29

Open
Abiaina wants to merge 29 commits into
Ada-C9:masterfrom
Abiaina:master
Open

Ampers Abinnet#29
Abiaina wants to merge 29 commits into
Ada-C9:masterfrom
Abiaina:master

Conversation

@Abiaina

@Abiaina Abiaina commented Apr 14, 2018

Copy link
Copy Markdown

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. two self.all methods to get the list of all the works in the work model and to get the first 10 works as well (although this assumed it was already ordered by total votes...it was an unordered list of works).
Describe how you approached testing that model method. What edge cases did you come up with? I created most of the testing before writing the models and after creating a simple ERD diagram
What are session and flash? What is the difference between them? session is similar to flash in that it stores data about the user as they are on the webpage. Session persists until the browser has been closed and flash stores info if you are rendering a new page not if you are redirecting.
Describe a controller filter you wrote. find_user looked for all the users that had the user_id obtained from params or from session. It was written in the controller parent class and instead of a before called before the user or other class I used a helper method to call the find_user method. This dryed up some of my code.
What was one thing that you gained more clarity on through this assignment? I really got a better understanding that I need to change how I am studying and completing assignments for Ada. I really struggled with this project, I am hoping to watch the lectures again this weekend and see if I can cover my gaps in understanding.
What is the Heroku URL of your deployed application? https://media-ranker-c9.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? None at the moment

Abiaina added 29 commits April 9, 2018 16:35
@tildeee

tildeee commented Apr 24, 2018

Copy link
Copy Markdown

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
Rails fundamentals (RESTful routing, use of named paths) x, but some routes are strange
Semantic HTML x
Errors are reported to the user yes but not with correct messages
Business logic lives in the models x
Models are thoroughly tested, including relations, validations and any custom logic not on custom logic
Wave 1 - Media
Splash page shows the three media categories x
Basic CRUD operations on media are present and functional broken
Wave 2 - Users and Votes
Users can log in and log out x
The ID of the current user is stored in the session x
Individual user pages and the user list are present x
A user cannot vote for the same media more than once
All media lists are ordered by vote count
Splash page contains a media spotlight
Media pages contain lists of voting users bad formatting
Wave 3 - Styling
Foundation is used appropriately
Look and feel is similar to the original
Overall

Oh nooo! Abinnet, let's chat sometime about what happened with this project!
The major things about this project that were rough was the lack of implementation of the following features:

  • logic around votes:
    • ordering works by votes
    • a user voting on a work more than once
    • displaying votes
  • Formatting for all messages: error messages, flash messages, a lot of the site content, user pages
  • Couldn't make a new work model, I kept getting errors
  • Didn't get to styling

Also there were a couple of routes that worked, but I'm unsure if you needed? Such as the show route for the vote.

That being said, I'm happy with what's there, and I'm happy with the tests on the models.

Let me know what's been challenging for you sometime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants