Ampers Steffany by steffnay · Pull Request #40 · Ada-C9/MediaRanker

steffnay · 2018-04-14T16:28:15Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I made Publication#get_highest, which sorts the category of publication by most votes and returns the specified number of top publications. It takes the parameters "number" and "category."
Describe how you approached testing that model method. What edge cases did you come up with?	I spent a long time trying to work on testing custom model methods but need some more help with that.
What are `session` and `flash`? What is the difference between them?	They are both hash-like objects that Rails creates for making data persist from one request to another. With session, data is stored indefinitely between request cycles until the browser is closed or the session is ended. Flash stores data only for the next request cycle.
Describe a controller filter you wrote.	I added find_user before filter to the Application controller. This method finds the user information before running any controller method in the program. This makes sure that the program keeps track of whether a user is logged in and who that user is.
What was one thing that you gained more clarity on through this assignment?	I understand a lot more about the different relationships between classes, models, and controllers in Rails. I think I did a better job of keeping business logic out of the controller compared to RideShare, though I am still working on this. I also understand sessions a lot more than I did when we were going over it in class.
What is the Heroku URL of your deployed application?	Link
Do you have any recommendations on how we could improve this project for the next cohort?	I think you all did a good job of covering a lot of information. Using Ada-books was extremely helpful for learning and those examples were crucial to getting through the project. I do think it would be helpful to go over more examples of testing in Rails, though. It would have helped me to see some examples of testing custom model methods.

…to upvote

…ex view to display votes for each publication

…ow pages

CheezItMan · 2018-04-18T15:38:18Z

Media Ranker

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good git hygiene
Comprehension questions	Check
General
Rails fundamentals (RESTful routing, use of named paths)	You have routes for votes that you don't need.
Semantic HTML	Yes, although your `header` and `main` elements are not nested inside the `body` element.
Errors are reported to the user	Errors are not reported for errors creating or updating publications. They are reported for duplicate upvotes or upvoting without being logged in.
Business logic lives in the models	Check, I really like your `highest` methods, they make good use of the `order` method and `limit`.
Models are thoroughly tested, including relations, validations and any custom logic	Overall pretty good, I left some notes in your code. You are missing some tests for custom methods in publications.
Wave 1 - Media
Splash page shows the three media categories	Check
Basic CRUD operations on media are present and functional	Check
Wave 2 - Users and Votes
Users can log in and log out	Check, although you need to check for some errors in the `create` action.
The ID of the current user is stored in the session	Check
Individual user pages and the user list are present	Check
A user cannot vote for the same media more than once	Check
All media lists are ordered by vote count	Check
Splash page contains a media spotlight	Check
Media pages contain lists of voting users	Check
Wave 3 - Styling
Foundation is used appropriately	Nicely done
Look and feel is similar to the original	Looks pretty close, not perfect but close.
Overall	Pretty good, you need to do more checking for errors and reporting them with `flash`, and more through testing, but you did hit all the major learning goals. I left comments in your code slack me if you have questions.

CheezItMan · 2018-04-18T15:12:08Z

+  end
+
+  def create
+    @publication = Publication.new(publication_params)


What about errors/flash notices here and in the update, destroy etc actions?

CheezItMan · 2018-04-18T15:13:28Z

+  end
+
+  def show
+    @user = User.find(params[:id])


You should probably have some error handling here incase you can't find that specific user.

CheezItMan · 2018-04-18T15:14:51Z

+    @publication.save ? (redirect_to publication_path(@publication[:id])) : (render :new)
+  end
+
+  def destroy


shouldn't I need to be logged in to delete, upvote, update or create a work?

CheezItMan · 2018-04-18T15:17:46Z

+  post '/login', to: 'sessions#create', as: 'login'
+  delete '/logout', to: 'sessions#destroy', as: 'logout'
+
+  resources :votes


Do you need all the routes here for votes? I think you should only have a route to create a vote, maybe nested under publications You wouldn't need a route for index, or new

CheezItMan · 2018-04-18T15:19:07Z

+    <%= csrf_meta_tags %>
+    <link rel="shortcut icon" type="image/x-icon" href="https://media-ranker-2-0.herokuapp.com/assets/favicon-910822ff6cd5f6d37119171c4b716f1d4e5fe0e8ad5e408627659ebf8d7f16b1.ico", alt: "site logo, an owl">
+  </head>
+  <header class="page-header">


The header, and main must be inside the body element.

CheezItMan · 2018-04-18T15:24:50Z

+describe Publication do
+
+  describe 'publication' do
+


You also need to have a test that a valid publication is valid, maybe using a fixture.

CheezItMan · 2018-04-18T15:25:26Z

+    end
+  end
+
+  describe 'self.find_votes' do


You also need to test edge-cases, maybe where a work has no votes, or there are no votes in the system, etc.

CheezItMan · 2018-04-18T15:28:13Z

+
+  it "requires a name" do
+    user = users(:bob)
+    user.name = ""


Odd, I was able to log into the site without giving my name, so something is strange here. Maybe you need to make sure that user.name must not be nil

CheezItMan · 2018-04-18T15:29:36Z

+      number_votes = Publication.find_votes(publication.category)
+      number_votes.length.must_equal 2
+    end
+  end


What about testing the spotlight, and highest?

CheezItMan · 2018-04-18T15:33:31Z

+      session[:user_id] = @user.id
+      flash[:success] = "Successfully logged in as existing user #{@user.name}."
+    else
+      @user = User.create(name: params[:user][:name])


You should have a check here to see if the create worked. What if someone tried to login with a space in their name?

steffnay added 30 commits April 9, 2018 15:11

Initial Rails setup

c1c85f3

initial setup plus MainsController#index and publications index

0311e11

added publication validations to model and began publication_test

3d31858

added more tests to publication_test

a205a06

added new and create to publication model, updated new view

7bc09f3

added edit to publications controller

fe0c4d6

added publication edit view

5881ff3

added publication#delete to model and updated publication show view

5749784

added basic tests to model user_tests

325e3ae

removed let assertion from user_test

ff68ada

added validations to user model

4a398f0

added formatting for see all publications/users to application.css

e4724d6

added users controller

ff5e9c7

added user#show and updated routes accordingly

e751a61

updated routes

07d5ff5

added login feature: updated application view and controllers

36e0141

added flash to application css

3f78e4d

updated sessions controller

c509589

updated votes_controller#new and #create, updated index view to link …

e64ad0e

…to upvote

added get_votes method to publication model, updated publications ind…

1e6d67c

…ex view to display votes for each publication

updated get_votes method in publications model

e3fd3fb

added basic tests to vote model

abc7230

added validations to vote model

92fc88c

added sort by votes to publication_controller index

91c7e94

styled main#index and updated publications#index to link titles to sh…

29458c0

…ow pages

updated publication year on show all media

bf6938a

updated links on publication#show

2f8e721

added votes to publcation#show

96c092c

updated css file types

4bbe59d

added conditional to spotlight on mains#index view

7f1aad3

steffnay added 14 commits April 13, 2018 14:13

debugging

043449e

added find_user to application controller

80f1f1a

updated total votes county in publication#show view

72220e9

pushing to heroku

c95a99a

pushing to heroku

a3de139

styled main#index view and css

7298c1f

added css for tables

917dca6

finally added title

ac71fe2

styled login view

a2c6411

added owl

9a4322d

deleted unused views

8dec123

DRYed up publications_controller

302b49a

updated tests

1eb4b74

added publication title links to user#show

676cc9d

CheezItMan reviewed Apr 18, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Ampers Steffany#40

Ampers Steffany#40
steffnay wants to merge 44 commits into
Ada-C9:masterfrom
steffnay:master

steffnay commented Apr 14, 2018

Uh oh!

CheezItMan commented Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

CheezItMan Apr 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

steffnay commented Apr 14, 2018

Media Ranker

Comprehension Questions

Uh oh!

CheezItMan commented Apr 18, 2018

Media Ranker

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants