Kiera - Hotel - Octos#18
Open
Krashaune wants to merge 15 commits into
Open
Conversation
…and hotel claslasses
…find_available_room and create_reservation.
…ying if the room is available
…t and days booked tests
…g an available le room
… updated tests tto reflect changes in methods
…list_reservations method to take in a date and output only reservations during that time
…e reservation ato mmake sure the room numbers are not the same.
…sting reservations and the dates overlaped. update reservation overlap to take in one parameter. completed and passed tests to check that find_available_method is working as intended.
| # go through @rooms array and sample a room_number | ||
| # with that room_number call reserevation_overlap? | ||
| # determine whether the new reservations date range overlaps | ||
| # with reservations in the reservation array |
There was a problem hiding this comment.
Doesn't quite seem like the code below accomplished everything you've outlined here
| end | ||
|
|
||
| # overlap? reservation needs to take in a date range and determine if it overlaps with self any other reservations ie boolean output | ||
| def reservation_overlap?(reservation) |
There was a problem hiding this comment.
Methods that have the ? should always return true or false. Here you're only returning one of those
HotelWhat We're Looking For
You did a good job in several of these method by outlining the purpose and then completing the implementation. I'd like to see how you continued to design given the completion of the remainder of the requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotel
Congratulations! You're submitting your assignment!
Comprehension Questions