Skip to content

Dikla Rikovitch Hotel Octos#26

Open
diklaaharoni wants to merge 7 commits into
Ada-C9:masterfrom
diklaaharoni:master
Open

Dikla Rikovitch Hotel Octos#26
diklaaharoni wants to merge 7 commits into
Ada-C9:masterfrom
diklaaharoni:master

Conversation

@diklaaharoni

Copy link
Copy Markdown

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? I needed to decide how many classes to create. I decided to create 4 classes that each class will have one responsibility
Describe a concept that you gained more clarity on as you worked on this assignment. I understand better how to work with classes
Describe a nominal test that you wrote for this assignment.
Describe an edge case test that you wrote for this assignment. raise an error if room is already reserved
How do you feel you did in writing pseudocode first, then writing the tests and then the code? i struggled in the beginning and I wrote the test after I wrote the code

@diklaaharoni

Copy link
Copy Markdown
Author

I don't have enough comments because I got an error when I tried to commit

Comment thread lib/period.rb
@check_out = check_out
end

def is_valid?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods that end in a ? should return true or false

@kariabancroft

Copy link
Copy Markdown

Hotel

What We're Looking For

Feature Feedback
Design
Demonstrated classes having a single responsibility Yes - I like the way you used a separate object to handle some of the date logic.
Demonstrated loose coupling Yes
Methods demonstrate a good use of encapsulation, inputs and outputs Yes mostly - there are only a few methods that could have improved outputs
Wave 1 requirements Yes
Wave 2 requirements No
Wave 3 requirements No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants