Ampers - Lily#18
Open
lillers1122 wants to merge 4 commits into
Open
Conversation
JS ScrabbleWhat We're Looking For
Looks great! Great job noting the Big O on these ;) The for each loops are a good chance to try out arrow function syntax -- if you have the free time to see how it looks, try it! Overall, good work |
tildeee
reviewed
May 23, 2018
| }); | ||
|
|
||
| let max_score = Math.max(...nums); | ||
| return scores[max_score]; |
There was a problem hiding this comment.
Interesting + good solution to use a hash and an array!
I haven't thought through it too deeply, but I wonder if there's a way to keep this solution while avoiding making the array nums... Your scores object is already keeping track of scores and words, so maybe you don't need it!
You really only use nums to find the max_score, so maybe there's a way to get the numerical scores out of scores and sort those and find the max...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions