Skip to content

Ampers - Lily#18

Open
lillers1122 wants to merge 4 commits into
Ada-C9:masterfrom
lillers1122:master
Open

Ampers - Lily#18
lillers1122 wants to merge 4 commits into
Ada-C9:masterfrom
lillers1122:master

Conversation

@lillers1122

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? I used a lot of the same logic: if statements and general design.
What was a challenge you faced in this assignment? Remembering to use semicolons...and taking advantage of JavaScript.
Do you have any recommendations on how we could improve this project for the next cohort? It was great! And compact! And the perfect assignment for this kind of a week.

@tildeee

tildeee commented May 23, 2018

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

Looks great!

Great job noting the Big O on these ;)

The for each loops are a good chance to try out arrow function syntax -- if you have the free time to see how it looks, try it!

Overall, good work

Comment thread scrabble.js
});

let max_score = Math.max(...nums);
return scores[max_score];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting + good solution to use a hash and an array!

I haven't thought through it too deeply, but I wonder if there's a way to keep this solution while avoiding making the array nums... Your scores object is already keeping track of scores and words, so maybe you don't need it!
You really only use nums to find the max_score, so maybe there's a way to get the numerical scores out of scores and sort those and find the max...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants