Skip to content

Ampers: Alex#21

Open
brownav wants to merge 11 commits into
Ada-C9:masterfrom
brownav:master
Open

Ampers: Alex#21
brownav wants to merge 11 commits into
Ada-C9:masterfrom
brownav:master

Conversation

@brownav

@brownav brownav commented May 18, 2018

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Applying logic was essentially the same, just getting the syntax correct took some translation.
What was a challenge you faced in this assignment? Nested arguments and keeping track of curly braces.
Do you have any recommendations on how we could improve this project for the next cohort? I think the project is solid.

@tildeee

tildeee commented May 23, 2018

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
score calculates score, has appropriate params and return value x
highestScoreFrom calculates highest scoring word, has appropriate params and return value x
Player object
Has name and plays properties x
Has play, totalScore, hasWon functions x
Has highestScoringWord and highestWordScore functions x
Overall

Your solution to highestScoreFrom is one of my favorites -- you made a data structure to keep the word and the score together in one thing with let highestScore = ["", 0];. A very elegant solution that helps keep track of both things.
The next step for refactoring that would be "could you turn it into an object" :)

Otherwise in general the code looks really good-- good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants