JS Scrabble - Emilce - Octos

[emilcecarlisa]

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript?	The conditionals and looping concepts were similar. Class and object structures were different enough to cause some confusion at first.
What was a challenge you faced in this assignment?	I struggled with some of the game logic when I tried to think of it on my own, then I decided to look at the Ruby implementation.
Do you have any recommendations on how we could improve this project for the next cohort?	I really liked all the in class examples/ mini lessons.

[droberts-sea]

JS Scrabble

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
score calculates score, has appropriate params and return value	yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value	yes
Player object
Has name and plays properties	yes
Has play, totalScore, hasWon functions	yes
Has highestScoringWord and highestWordScore functions	yes
Overall	Good work overall! I've left some inline comments for you to review, but in general this is a solid submission.

[droberts-sea]

I like this hash structure here.

[droberts-sea]

Instead of throwing a string, you should throw an instance of Error. That gives you access to stack trace information. Something like this:

if (condition) {
  throw new Error(`Invalid word ${word}`);
}

[droberts-sea]

I'm surprised (and a little impressed) that this works. However, stylistically it's hard to read, since this doesn't really match what a switch is meant to be used for. A regular if statement would probably be more clear.

[droberts-sea]

Good use of a helper method to simplify this logic.