Skip to content

Karinna Iniguez - JS Scrabble - Octos#26

Open
karinnainiguez wants to merge 5 commits into
Ada-C9:masterfrom
karinnainiguez:master
Open

Karinna Iniguez - JS Scrabble - Octos#26
karinnainiguez wants to merge 5 commits into
Ada-C9:masterfrom
karinnainiguez:master

Conversation

@karinnainiguez

Copy link
Copy Markdown

JS Scrabble

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What patterns were you able to use from your Ruby knowledge to apply to JavaScript? Iterating through strings and collections was pretty similar, so I was able to use the same types of methods I would have used in ruby.
What was a challenge you faced in this assignment? I tried googling enumerator equivalent for JS, but could not find something that was any more helpful than iterating through the collection myself. Also, JS does not stop the program and give me no-mehtod errors if I put something incorrect in my conditional. So I had a typo where I was calling collection.lenth and didn't find my mistake for like an hour because instead of getting a no "no method lenth" error, my tests were just failing.
Do you have any recommendations on how we could improve this project for the next cohort? It's pretty straight forward already, maybe go over the process to 'require' files. It was already done for us in this, but I feel like going through that would've been helpful.

@kariabancroft

Copy link
Copy Markdown

JS Scrabble

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Yes
Comprehension questions Yes
General
score calculates score, has appropriate params and return value Yes
highestScoreFrom calculates highest scoring word, has appropriate params and return value Yes
Player object
Has name and plays properties Yes
Has play, totalScore, hasWon functions Yes
Has highestScoringWord and highestWordScore functions Yes
Overall You used semi-colons occasionally but I'd like to see you work through this code and add them where they are necessary throughout. You did demonstrate your usage of the js functions and overall syntax in this assignment.

Comment thread scrabble.js
let letter = word.charAt(i).toLowerCase()
total += SCORE[letter]
}
return total

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did well with semi-colons at the beginning of this function but lost it by the end!

Comment thread scrabble.js

arrayOfWords.forEach(function(word){
if ( Scrabble.score(word) > highScore ) {
highScore = Scrabble.score(word)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using this function in both places, you are doing this calculating time. Consider storing in a variable so you only need to do the calculation once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants