Ampers - Sara S#31
Open
CheerOnMars wants to merge 5 commits into
Open
Conversation
JS ScrabbleWhat We're Looking For
|
CheezItMan
reviewed
May 20, 2018
| let letters = word.toUpperCase().split(``); | ||
|
|
||
| if (word.match(/^[a-zA-Z]{1,7}$/) == null) { | ||
| throw `How'd you get a non-letter tile, even?`; |
| } | ||
|
|
||
| hasWon() { | ||
| if (this.totalScore() >= 100) { |
There was a problem hiding this comment.
You could also simply
return this.totalScore() >= 100;|
|
||
|
|
||
| test('returns false when score < 100', () => { | ||
| const player = new Scrabble.Player('test player'); |
There was a problem hiding this comment.
It would be good to loop through until you reach 99, the edge case, and verify that hasWon() is false.
|
|
||
|
|
||
| test('returns true when score > 100', () => { | ||
| const player = new Scrabble.Player('test player'); |
There was a problem hiding this comment.
It would also be good to verify that 101 makes hasWon() true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions