Selam Ainalem - Amperes#46
Open
SelamawitA wants to merge 8 commits into
Open
Conversation
… letter and value as associated score. Created score(word), that has a word(string) as an input and returns the associated score. Created method highestScoreFrom(arrayOfWords) accepts an array of words returns the highest scoring word. All methods have only been tested in the terminal. git push origin master
…constructor that accepts a name of a player. Added play(word) - pushes played word into plays array, added totalScore() - calculates a player's total score. added hasWon() - checks if a player has won, added highestScoringWord() - returns highest scoring word, added highestWordScore() - returns the score for the highest scoring word.
…se is covered and passing.
… the highestSCoringWord() method from being invoked w/o a word being played. Also created a new test for highestWordScore().
…g invoked without a word being played. Tested method. All methods are currently passing. Need to update tests for edge cases.
JS ScrabbleWhat We're Looking For
|
CheezItMan
reviewed
May 20, 2018
| const Scrabble = { | ||
| score(word) { | ||
|
|
||
| score_per_char(){ |
There was a problem hiding this comment.
It makes more sense to have this as an object rather than a function which returns an object.
| throw new Error('Word length must be at least 1 character.') | ||
| } | ||
|
|
||
| if (/^[a-zA-Z]*$(?=)/.test(word) === false){ |
| } | ||
|
|
||
| play(word){ | ||
| if (word === null){ |
There was a problem hiding this comment.
Since both null and undefined are falsy, you could just do
if (!word) {
throw new Error(`${word} is not valid word`);
}| if (user_has_won){ | ||
| return false | ||
| }else { | ||
| if (word.length) |
There was a problem hiding this comment.
What purpose does this if statement serve?
| } | ||
|
|
||
| hasWon(){ | ||
| if (this.totalScore() >= 100){ |
There was a problem hiding this comment.
You could also have:
return this.totalScore() >= 100;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS Scrabble
Congratulations! You're submitting your assignment!
Comprehension Questions