Angelica & Cara - Rideshare Rails - Octos by amcejamorales · Pull Request #15 · Ada-C9/rideshare-rails

amcejamorales · 2018-04-06T22:55:44Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up Drivers and Passengers to have many Trips because each trip could only have one passenger and one driver, but each driver or passenger could have multiple trips.
Describe the role of model validations in your application	We used model validations to ensure that each passenger had a name and a phone number and that each driver had a name and a vin. This was to ensure we didn't get any errors when calling on this information.
How did your team break up the work to be done?	We worked together on big chunks of the main portion of the program, Trips, and each took Drivers and Passengers. We communicated over slack to divvy up styling.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We decided Trips was the most important so we set it up first, but then worked on our individual components and came back together for Trips as different functionalities became relevant. We did not figure out how to include a float field in the search bar, so we didn't allow the user to search by cost like we had initially planned.
What was one thing that your team collectively gained more clarity on after completing this assignment?	How the files relate to each other. When we changed something in one file we got a better sense of how this would affect files elsewhere.
What is your Trello URL?	https://trello.com/b/xnIu9Mug/rideshare-rails-422018
What is the Heroku URL of your deployed application?	https://rideshare-rails-ac.herokuapp.com/trips
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	One thing we discussed was that we worked well and communicated both in person and over slack. Another thing we could improve on would be checking for understanding each step of the way so both parties know why we're taking the project in a certain direction.

…d Trip

…s' trips

We are working on different things, and are combining our two parts.

…ails

…llars in Passenger and Trips views.

…ails

Yes this is fine

Merging back to original after adding search bar for passengers

…ails

Changes to Trips search bar

kariabancroft · 2018-04-09T21:14:44Z

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Mostly. I'd like to have seen more equitable contributions from Cara early on in the project.
Answered comprehension questions	Yes
Uses named routes (like `_path`)	Yes
RESTful routes utilized	`resources` routes look good though there are others that are extraneous and should not be used.
Rideshare Rails Specific Content
Table relationships	Looks good in the schema as well as the model files
Validation rules for Models	Yes, using `presence` validators in the models
Business logic is in the models	Yes, there is definitely some cost and search logic in the model methods. This does a nice of preventing logic from showing up in the views unnecessarily.
Database is seeded from the CSV files	Yes, data on Heroku deployment looks good.
Trello board is created and utilized in project management	Yes, nice job organizing by waves
Postgres database is used	Yes
Heroku instance is online	Yes
The app is styled to create an attractive user interface	Yes - see some comments inline on the code
Overall	You did a nice job hitting the major learning goals of this assignment. Overall, the biggest style issue I noticed is indentation! Since the views don't update this automatically, it is really important to do this yourself. It makes the view code a lot easier to read when it is structure appropriately.

kariabancroft · 2018-04-09T20:16:04Z

+  get 'trips/index'
+
+  # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
+    root 'home#index'


For readability, we put the root route at the top of the routes file.

kariabancroft · 2018-04-09T20:16:49Z

+Rails.application.routes.draw do
+  get 'passengers/index'
+
+  get 'passenger/index'


Why would you have both this route and a plural version, neither of which follow the RESTFUL standard or get mapped to a controller action?

kariabancroft · 2018-04-09T20:23:53Z

+<%= submit_tag "Search" %>
+<% end %>
+
+<section class = "add-link">


When we use classes in our HTML, we do not use the same spacing conventions as we do in our Ruby code. We should not put spaces on either side of the equal, so: class="add-link"

kariabancroft · 2018-04-09T20:24:27Z

+    <%= link_to driver.name, driver_path(driver) %>
+    </strong>
+  </li>
+</aside>


Watch your indentation here - its not right and makes the view code much harder to read than it needs to be.

kariabancroft · 2018-04-09T21:00:05Z

+  belongs_to :passenger
+
+
+def convert_to_currency(n)


EEK! Watch indentation here - this is challenging to read

kariabancroft · 2018-04-09T21:09:49Z

+  Driver's Average Rating: <%= @driver.average_rating %>
+</p>
+<p>
+  Driver's Trips:


I'm not sure what happened with this section, but it ends up being really difficult to read. Recommend creating an overall semantic section of some sort of encapsulate all of this trip information. As well as possibly another HTML container that would contain the details of one piece of trip info.

kariabancroft · 2018-04-09T21:12:03Z

+class DriversController < ApplicationController
+  def index
+    @drivers = Driver.all
+    if params[:search]


Nice job using the same route and pivoting on the params to determine which logic to execute

kariabancroft · 2018-04-09T21:12:46Z

@@ -0,0 +1,50 @@
+class PassengersController < ApplicationController
+  def index
+    @passengers = Passenger.all


By doing this first, you'll be doing an extra database query that you don't need. You only need the queries in the conditionals.

kariabancroft · 2018-04-09T21:13:01Z

@@ -0,0 +1,61 @@
+class TripsController < ApplicationController
+  def index
+    @trips = Trip.all.order(:id)


Same comment re: extra DB query

kariabancroft · 2018-04-09T21:13:46Z

+  end
+
+  def create
+    passenger = Passenger.find_by(id: params[:passenger_id])


This would potentially be good logic to move into the Trip object so that all of the defaults would be captured there instead

amcejamorales and others added 30 commits April 2, 2018 15:56

Create new rails project

61d8338

Created Trips MVC

cf0327a

Refactor routes

aa5c9e0

Set up Trip controller index method and view

22a7d13

Set up Driver controller and active record relation between Driver an…

0dac52f

…d Trip

Initial Passenger MVC

4643512

Reset Driver Controller

d24cfbc

Resolved merge conflict by incorporating both suggestions.

1ae0d29

Update Passenger model phone number column name

d0ef1cd

Added Passenger-Trip relationships

3fda25b

Update Driver index page

cc5b620

Create show view for Driver and update show method

df2e843

Update Driver index view to link each driver to show view

417a3d6

Create form for Driver new and edit views

f679f40

Set up new view for Driver

f54a4c3

Set up create method for Driver

dcc5f27

Set up edit view and method and update method for Driver

bfe58a4

Set up destroy method for Driver

c8a06a9

Update Driver show view to display information for each of the driver…

03dfded

…s' trips

Initial Views set up for Passenger

6dc7e14

Merge branch 'master' of github.com:amcejamorales/rideshare-rails

734c51f

We are working on different things, and are combining our two parts.

Add #total_earnings to Driver and update show view

c5f05bd

Add #average_rating to Driver and update view

ace6d11

Passenger view, edit, index, new views.

2fce30f

Link each driver's trips to corresponding trip show view

e59002b

Merge branch 'master' of https://github.com/amcejamorales/rideshare-r…

04af9f1

…ails

Adding in Trips methods

4701cdc

Write create method for Trips

6291f00

Added show method for trip and trips.

5e1b303

Modify Trips index view

db5aa2b

MississippiBrenn and others added 28 commits April 5, 2018 14:01

Added ability to delete and change rating in trip

0897d09

Update passenger to be able to request new trip

96b5187

Created links to passenger and driver in trips show page

fc78abc

Completed Passenger methods and links to trips, converted cents to do…

2b2fb1b

…llars in Passenger and Trips views.

Added new passenger path

9eac840

Delete empty file

38ec9b5

new Passenger process complete

1a8e154

Validate driver name and vin

97afa7d

Merge branch 'master' of https://github.com/amcejamorales/rideshare-r…

ea24f49

…ails

Added validation to Passenger

90a01b0

Merge branch 'master' of github.com:amcejamorales/rideshare-rails

17be7ba

Yes this is fine

Fixed some typos around AR validation

364d2d0

Set styles for navigation menu over entire site

19a309e

initial css for passenger

4b21095

More CSS styling for Passenger index

cefa947

Add styles to trips

8114331

final CSS drying

eaf7222

Add Driver styles and update navigation menu styles

d55b7bf

Added search bar for passenger index view

15fa107

Merge branch 'master' of github.com:amcejamorales/rideshare-rails

d38d9ad

Merging back to original after adding search bar for passengers

Add form styles

c49350b

Merge branch 'master' of https://github.com/amcejamorales/rideshare-r…

2f839e6

…ails

Added a search bar for drivers

b0e7eae

Add more form styles

adc5778

Update form styles for search

96c2c8a

Merge branch 'master' of https://github.com/amcejamorales/rideshare-r…

1dbb2c8

…ails

Trips changes

3ba3d90

Merge branch 'master' of github.com:amcejamorales/rideshare-rails

ec368cf

Changes to Trips search bar

kariabancroft reviewed Apr 9, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Angelica & Cara - Rideshare Rails - Octos#15

Angelica & Cara - Rideshare Rails - Octos#15
amcejamorales wants to merge 59 commits into
Ada-C9:masterfrom
amcejamorales:master

amcejamorales commented Apr 6, 2018

Uh oh!

kariabancroft commented Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

kariabancroft Apr 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

amcejamorales commented Apr 6, 2018

Rideshare-Rails

Comprehension Questions

Uh oh!

kariabancroft commented Apr 9, 2018

Rideshare-Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants