Ampers: Lily, Alex

[brownav]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We nested some trip actions in driver and passenger.
Describe the role of model validations in your application	When adding and editing forms, we required validations for presence all attributes, and numericality for cost.
How did your team break up the work to be done?	We did most of it at the same time, we broke up some styling tasks.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We mostly stuck to basic features, rating has a drop-down. Given more time, we would have added a feature to determine driver availability when a trip is requested.
What was one thing that your team collectively gained more clarity on after completing this assignment?	MVC relationships.
What is your Trello URL?	https://trello.com/b/bxC4RcAu/rails-rideshare
What is the Heroku URL of your deployed application?	https://la-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Better communication concerning git, and differing communication/work styles.

[tildeee]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Rideshare Rails Specific Content
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Postgres database is used	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

Overall, looks good! The routes and functionality of the app are all that we expected. Runs pretty smoothly!

It's a shame that the rating wasn't done in a view and not through the trip edit page! That's okay, next time!

The formatting of the trip prices could be better-- you two usually used code like this $<%= @trip.cost.to_f/100%> in the views, but it displays prices like "$100.0" or "$100.1" instead of "$100.00" or "$100.10".

Otherwise, the code looks good. Great work