Brenda and Brandy - Rideshare - Octos

[brandyaustinseattle]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	Passengers have many trips and drivers have many trips as well. We did it this way because trips can only have one passenger and one driver but the passengers and the drivers can have many trips.
Describe the role of model validations in your application	The validations confirmed the presence of a name and phone number for a passenger. For drivers we validated the presence of a name and a vin number.
How did your team break up the work to be done?	At the beginning, we divided the work by classes. Brenda worked with drivers, Brandy with passengers, and then we both worked on trips. After the web app was working, we started styling and divided the work by feature.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized making it possible to retrieve all of the information in trips. We tried to set aside any added features and complete all the requirements first. We could have done some more styling in certain areas.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained clarity on the use of nested routes and routes in general. Using the command rails routes helped us a lot when we needed to debug and fix pages.
What is your Trello URL?	https://trello.com/b/mY7e6PDv/rideshare
What is the Heroku URL of your deployed application?	https://bb-rideshare.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We discussed how we went about splitting up the work and our willingness to be flexible in that regard. We also talked about how we worked together when stuck in certain areas.

[kariabancroft]

I might argue against returning the formatting string here. The value is what is important for this model method, and formatting that should probably be the responsibility of the view

[kariabancroft]

What does this do for you? Would this be saved or used later anywhere?

[kariabancroft]

This is more appropriate in the application.html.erb file than in a specific view file

[kariabancroft]

This is a nitpick, but for CSS class names, we use the - rather than the _ to separate words, so this would be passengers-show instead.

[kariabancroft]

Nice!

[kariabancroft]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Yes
Answered comprehension questions	Yes
Uses named routes (like _path)	Yes
RESTful routes utilized	Yes - when you have to list most of the RESTful options, it is preferable to use except over only to simplify the list
Rideshare Rails Specific Content
Table relationships	Yes - the relationship looks good in both the schema file and the model files
Validation rules for Models	Yes - primarily using the presence validation
Business logic is in the models	Yes - totals, rating and cost logic in model methods
Database is seeded from the CSV files	Yes
Trello board is created and utilized in project management	I think so - but it wasn't public so I couldn't verify
Postgres database is used	Yes
Heroku instance is online	Yes
The app is styled to create an attractive user interface	Yes - very nice overall look & feel. Data was easily accessible and readable across pages - I liked the tables you used to organize certain pieces of data.
Overall	You did a nice job overall hitting the major learning goals of this assignment.