Tor Shimizu - Wini Irarrazaval - Octos - Rideshare Rails by winirarrazaval · Pull Request #26 · Ada-C9/rideshare-rails

winirarrazaval · 2018-04-07T00:47:57Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A driver has many trips, a passenger has many trips, a trip belongs to one passenger and one driver.
Describe the role of model validations in your application	We had validations to ensure that a person entered a name and vin if a driver, and a phone number if passenger. We also had a validation for trip ratings being between 1..5.
How did your team break up the work to be done?	We worked on complicated features together, and for easier things (calculating costs and average rating) we split up by passenger and driver. Tor did mostly CSS and Wini did the heavy logic of finding a driver who has not worked in the least amount of time.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We included all basic requirements and at first chose a random driver for a trip until we had more requirements done, then went back and chose the driver who has not worked in the longest. We also left the layout for last.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained more clarity on the MVC structure and are more comfortable with routes and the controller directing to the model or view.
What is your Trello URL?	https://trello.com/b/Tu0XuJto/ride-share
What is the Heroku URL of your deployed application?	https://mr-octopus-rideshare.herokuapp.com
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Wini - I like how Tor had the patience to teach me when I didn't understand and pushed me to do stuff that even though Tor knew how to do, made me do the thing to learn how to do it instead.
Tor - I liked how Wini would be excited to try new things and would be willing to do the new things. I really appreciated that Wini would have good ideas that she would mention aloud and make us try. I appreciated that if I had ideas, she was willing to try it.
We both could trust that the other could get separate things done at home.

…s index

… in the edit.html.erb and new.html.erb views. We are able to update and add drivers

…ndex

…iew the info of each trip.

…ngs methods. Then I added them to the driver/show

…rails

…bmitted

…ant be black to be able to submit

…irect to the same page

… cases and updated driver#destroy to replace the driver in its trips with a placeholder driver before destroying the selected driver

… or not

…that has the longest time with no tripss

…uming that if there is a trip with no rating is still in trip

…able driver, added some styling to driver page

…er show page, will display a form to get rating

…rails

droberts-sea · 2018-04-13T21:51:53Z

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	yes
Answered comprehension questions	yes
Uses named routes (like `_path`)	yes
RESTful routes utilized	yes - some extra, see inline
Rideshare Rails Specific Content
Table relationships	yes
Validation rules for Models	yes
Business logic is in the models	yes - see inline comments
Database is seeded from the CSV files	yes
Trello board is created and utilized in project management	yes
Postgres database is used	yes
Heroku instance is online	yes
The app is styled to create an attractive user interface	yes - good work
Overall	Great job overall! I've left some nitpicks below, but in general I am quite pleased with this submission. Keep up the hard work!

droberts-sea · 2018-04-13T21:22:45Z

+end
+
+resources :trips, except: [:destroy]
+resources :rideshare, only: [:index]


I like that you're excluding the destroy route on trips, but I think you could go even further. It doesn't look like new or the un-nested create routes are being used.

droberts-sea · 2018-04-13T21:27:42Z

+  def self.the_driver
+    drivers = Driver.where(disabled: false)
+    longest_driver_not_driving = drivers.first
+    drivers.each do |driver|


I'm not sure about the name of this method - if I hadn't seen this file and I saw a call to Driver.the_driver, I would not know what that method is doing. Something like select_driver might be more mnemonic.

droberts-sea · 2018-04-13T21:37:44Z

+
+  def driver_on_trip
+    self.trips.each do |trip|
+      return true if trip.rating == nil


In general, you don't need to include the name of the class in an instance method for that class. Also, since this method returns true or false, the Ruby convention is to end the name in a question mark. So this one should be on_trip?.

droberts-sea · 2018-04-13T21:42:38Z

+    <% if model = @passenger %>
+      <%= f.label :phone_num, class: 'label' %>
+      <%= f.text_field :phone_num, class: 'control input' %>
+      <%= f.submit action_name, class: 'control button is-link' %>


While I appreciate the enthusiasm, the fact that you've got a big if statement here indicates you may have gone too far trying to DRY this up. I would probably have made the errors and hero section their own partial, and written a separate form_for for driver and passenger.

droberts-sea · 2018-04-13T21:48:20Z

+<h4> Trips: </h4>
+  <ul class='display-trips'>
+    <li>ID</li>
+    <li>Date</li>


Good work breaking this out as a separate view partial!

winirarrazaval and others added 30 commits April 2, 2018 15:22

We added rails

0fa4ab2

created Driver and Passenger models

142c169

ralated trip and driver

dd7d2b7

related passenger and trip models, added relationships in model

4097ca9

Created a controller for each model

43fc578

added all routes

0f763c1

fixed belongs_to in trip

a74cdfc

added passengers_controller methods

0570ed6

added index view for passengers

ea6a83b

Added the methods for the driver controller and a template for driver…

02cac59

…s index

Added a template (view) for the driver show action

0b4d90b

Added a form for editing and creating a new driver, and then using it…

d9a2304

… in the edit.html.erb and new.html.erb views. We are able to update and add drivers

Fixed a bug in controller

0e49ca3

made a main website page, linked it to drivers#index and passengers#i…

cbc55ed

…ndex

added views for passenger, updated action name for drivers partial

36722a3

fixed form to find a drivers show page by name

c482819

Added partial form for searching by name both driver and passenger

5fb4e36

added nested routes for trip in passenger and driver

91d16b5

Added a link to edit and delete action for the drivers show vision

57ca80c

Added feature to be able to get into every of the drivers trips and v…

767be74

…iew the info of each trip.

fixed some of the trip show.html

33e52e7

Added business logic to driver model, with a average_rating and earni…

1e41bb9

…ngs methods. Then I added them to the driver/show

added a total spent method to passenger, added to passenger view

1531b56

Merge branch 'master' of https://github.com/winirarrazaval/rideshare-…

dbb5a40

…rails

passenger can request a new trip and rating will update on page if su…

52da061

…bmitted

rounded assigned cost of trip to 2 decimal places

66fc741

Added a link in layout view to create a new passenger and driver

e3fe171

Added feature to the partial by_name to require that the text field c…

472a4bd

…ant be black to be able to submit

If driver or passenger not found in serch, on index view, it will red…

84ac7c4

…irect to the same page

updated driver calculate earnings and average rating to deal with nil…

004b04d

… cases and updated driver#destroy to replace the driver in its trips with a placeholder driver before destroying the selected driver

torshimizu and others added 28 commits April 5, 2018 14:26

minor css changes

8a4a999

validation and display error messages

566a377

added before action to create driver 9999 when destroying a driver

bafc2b7

updated destroy driver

12eb9a8

Tried make foreign keys take nil

d4e5eb0

made a column in Driver and Passenger that is toggleable for disabled…

8caad4c

… or not

uploading the file for disabled column and some css updates

bc42545

Added feature when finding a driver for a new trip to choose the one …

3c771fc

…that has the longest time with no tripss

Added a bussiness logig method to check if the driver is on trip, ass…

5c5dc7c

…uming that if there is a trip with no rating is still in trip

added some ideas for business logic in driver model for finding avail…

71393eb

…able driver, added some styling to driver page

keeping both driver logic to determine what to do later

52fc5c6

Was able to move the ugly code from controller to the driver model

44e48f6

added page stylings and if rating is incomplete on driver and passeng…

4259cc6

…er show page, will display a form to get rating

Merge branch 'master' of https://github.com/winirarrazaval/rideshare-…

f0cd39a

…rails

changes

87465a2

Merge branch 'master' of https://github.com/winirarrazaval/rideshare-…

a0ad919

…rails

updated average rating, should have a working method, need to test

4034ffc

fixed average_rating method

13cbcd4

passenger index page formats

7222325

added a not found message when driver o passenger not found

4a84393

added not found to seach bar

a8ddfde

done

c73d70e

added driver and passenger not found for search

bece5dd

fixed passenger page styling

a21f00d

fixed a bug

60f0314

added a partial for passenger and driver new and edit views

21f4719

updated error showing when rating a trip other than 1..5

d72d3fb

changed edit info to look like a button

e9adbe5

droberts-sea reviewed Apr 13, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Tor Shimizu - Wini Irarrazaval - Octos - Rideshare Rails#26

Tor Shimizu - Wini Irarrazaval - Octos - Rideshare Rails#26
winirarrazaval wants to merge 62 commits into
Ada-C9:masterfrom
winirarrazaval:master

winirarrazaval commented Apr 7, 2018

Uh oh!

droberts-sea commented Apr 13, 2018

Uh oh!

droberts-sea Apr 13, 2018

Uh oh!

droberts-sea Apr 13, 2018

Uh oh!

droberts-sea Apr 13, 2018

Uh oh!

droberts-sea Apr 13, 2018

Uh oh!

droberts-sea Apr 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

winirarrazaval commented Apr 7, 2018

Rideshare-Rails

Comprehension Questions

Uh oh!

droberts-sea commented Apr 13, 2018

Rideshare-Rails

What We're Looking For

Uh oh!

droberts-sea Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

droberts-sea Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

droberts-sea Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

droberts-sea Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

droberts-sea Apr 13, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants