Nora & Zheng initial setup/trello board check by npeters5 · Pull Request #8 · Ada-C9/rideshare-rails

npeters5 · 2018-04-03T16:30:03Z

Here's link to Trello board, where we've attached our ERDs: https://trello.com/b/bC84mDCv

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We set up three entities: Driver, Passenger, and Trip. Drivers have many trips, and passengers have many trips, and a trip belongs to one driver, and belongs to one passenger. We decided that a trip should only have one passenger for now.
Describe the role of model validations in your application	In the Driver and Passenger models we used validates_presence_of to make sure that user provides input for certain fields (name, vin, etc), and used validates :cost, numericality: true in the trip model to make sure that cost input is numerical. We also added code to the view to reveal the errors.
How did your team break up the work to be done?	We started by translating requirements to tasks on Trello, grouping tasks into like categories, and arranging by highest priority. We finished initial setup of the project together, then split up Passenger and Driver, working on separate branches remotely. Then we came bak together to work on Trip, troubleshoot issues and make to-do lists with smaller subtasks, and collaborated well remotely via Slack, and continuously pushed and pulled to git and deployed to Heroku.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We chose to set aside most of the styling as lower priority, and chose to focus on things like the 'request trip' link on passenger detail page being hidden if the passenger had unrated trips (this works on localhost, but buggy on Heroku...troubleshooting Heroku logs), inserting a datepicker and drop-down menus in our forms, listing all drivers from highest to lowest rating in index page, and updating driver status from available to unavailable after they are selected for a trip.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained more clarity on the model and logic inside the model, validations, how params work, as well as resources and nested routes.
What is your Trello URL?	https://trello.com/b/bC84mDCv/rideshare-rails
What is the Heroku URL of your deployed application?	https://np-zc-ridesharerails.herokuapp.com/

…ding

…ion, partial view form and private params

…_date on trip show page

…tes w/root. creates global nav bar"

…lumn. modifies seeds.rb to set all drivers to is_available = true

…tion. adds form for rating.

…strong_params, and change order of list for easy testing

… check and update trip strong params to be consistent with schema

…date action

CheezItMan · 2018-04-09T00:46:56Z

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Check, good number of commits and both partners contributed.
Answered comprehension questions	Check
Uses named routes (like `_path`)	Check
RESTful routes utilized	Check, nice work not including unused routes
Rideshare Rails Specific Content
Table relationships	Check
Validation rules for Models	Check, need a validation on `Trip` where it should be between 1 and 5, and allow nil
Business logic is in the models	For the mot part, some things should be in the model that are in the controller.
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check
Postgres database is used	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Minimal styling, but that's not a requirement
Overall	You've got a few issues with code in the controller that should be in the model and a few odd things in the `TripsController`. Check out my notes there and let me know if you have any questions. You did hit all the learning goals. Well done.

CheezItMan · 2018-04-08T23:45:14Z

+        <li>Total Earnings: $<%= @driver.total_earnings %></li>
+        <li>Average Rating: <%= @driver.average_rating %></li>
+        <li>VIN: <%= @driver.vin %></li>
+        <li>Status: <%= @driver.is_available? ? "Available" : "Unavailable" %> </li>


How do you make a driver available?

CheezItMan · 2018-04-09T00:35:19Z

+    sprintf('%.2f', (self.cost / 100))
+  end
+
+  def pretty_date


👍

You'll learn later about view_helpers and that might be more useful later as a view helper.

CheezItMan · 2018-04-09T00:38:28Z

+              <%= trip.rating %>
+            <% else %>
+              <% @rate_first = true %>
+              <%= form_for trip do |f| %>


CheezItMan · 2018-04-09T00:40:27Z

+  belongs_to :driver
+  belongs_to :passenger
+  validates :cost, numericality: true
+


What about validating the rating between 1-5?

CheezItMan · 2018-04-09T00:41:39Z

+    @trip = Trip.new
+    @trip.date = DateTime.now
+    @trip.cost = rand(9999)
+    driver = Driver.all.where(is_available: true).sample


It would make sense to put a method in Driver to get an available driver.

CheezItMan · 2018-04-09T00:42:26Z

+    driver = Driver.all.where(is_available: true).sample
+    @trip.passenger_id = Passenger.find_by(id: params[:passenger_id]).id
+    if driver
+      @trip.driver_id = Driver.all.where(is_available: true).sample.id


You seem to be finding a driver twice here.

CheezItMan · 2018-04-09T00:42:36Z

+        raise ArgumentError.new("Error: Trip not created.")
+      end
+    else
+      flash[:notice] = "No driver is available at this moment."


Flash notices, sweet!

CheezItMan · 2018-04-09T00:44:26Z

+
+    if @trip
+      @trip.destroy
+      flash[:notice] = "You successfully deleted this trip."


You should probably redirect someplace, maybe root, maybe back to the passenger or driver.

CheezItMan · 2018-04-09T00:45:15Z

+      if @trip.update(trip_params)
+
+        if params[:trip][:cost_in_dollar]
+          @trip.cost = params[:trip][:cost_in_dollar].to_i * 100


If this is true and the rating is not included, the trip won't be saved.

npeters5 and others added 30 commits April 3, 2018 08:47

initial setup. generate controllers and models, run migration and see…

8e18160

…ding

Add routes, finish index page for passenger

8b8cbd8

Implement new & create for passenger controller

40bacaa

Implement edit and update for passenger controller

c5391ea

Implement delete for passenger controller

8614ba9

Implement total_cost in Passenger model

a9b0107

Add routes for Trip, finish Passenger detail page

7633447

Implement request_trip for Passenger model

fa4061b

adds driver controller, routes, and views + some model logic, validat…

aac25b7

…ion, partial view form and private params

removes everything from routes besides resources :drivers

cb15e44

Clean up routes

439be07

merge conflict in routes resolved

bf76cef

modifies driver model logic and minor string errors in driver show view

c24a7c2

Implement trip show controller action and show view

9d4ccb6

Implement pretty_date in trip model, add trip.id to header and pretty…

9a7affe

…_date on trip show page

Implement trip edit controller action and edit view

2479ce4

Implement trip update controller action and redirect to show view

1c743eb

Implement trip destroy controller action

bc74638

Add better_errors and binding_of_caller to gemfile

32d510c

creates welcome controller with index only for root_path. updates rou…

379a309

…tes w/root. creates global nav bar"

implement request new trip. updates driver model with is_available co…

5288c2c

…lumn. modifies seeds.rb to set all drivers to is_available = true

updates passenger show view. adds update rate route and controller#ac…

e933e40

…tion. adds form for rating.

fixes trip detail show view with form_for rating with default blank

54c94ed

Fix cost bug on trip show view

6628b47

Fix datepicker bug on trip show view

2af0347

Show flash[:notice] in trip destroy view

639188b

Modify update action in tripController to fix cost bug

f462af3

Delete rate_trip method in Passenger model

fdc0c97

updates driver#average_rating

a62f7af

Implement driver created action, add validation, add is_available to …

4b1903c

…strong_params, and change order of list for easy testing

2020dream and others added 26 commits April 5, 2018 21:53

Merge branch 'master' of https://github.com/npeters5/rideshare-rails

4652c7c

adds rating form to passenger show view

3f40eba

fixes divide by 0 bug in driver#average_rating

29e992a

Implement driver destroy action

b67b032

Delete trips after deleting driver/passenger

4978efb

Add rating, edit and delete to All Drivers page

ed45946

styles passenger and driver show and index views + root route

489db9c

adds name to passenger show page header

1095f8c

Add $ to cost on trip show view

739ab92

Remove unused routes by comparing routes and controllers, also double…

093de9c

… check and update trip strong params to be consistent with schema

Set driver status to unavailable in create action and available in up…

ed7a1e5

…date action

Only request a trip after rating all trips

9588e47

Redirect to passenger show view after rating a trip

9faf05e

rounds cost to 2 decimal points and rating to one

d2d3b6c

Merge branch 'master' of https://github.com/npeters5/rideshare-rails

ba99dd0

Use table for passenger index view

b651167

Update trip controller update action

695dae7

Delete unused view files

d85c0a5

wraps flash notice on trip destroy view in h2 tag for visibility

9b52bd9

adds conditional logic on trip edit view for rating field

ec478e7

List drivers according to average rating

b4d0513

Merge branch 'master' of https://github.com/npeters5/rideshare-rails

77380a8

styles passenger and driver show views

0339147

Merge branch 'master' of https://github.com/npeters5/rideshare-rails

c933152

fixes request trip button in passenger show view

1052b91

Fix heroku 500 error when request a new trip

ac559c1

CheezItMan reviewed Apr 9, 2018

View reviewed changes

Fix default value bug for rating on trip edit view

f53a312

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nora & Zheng initial setup/trello board check#8

Nora & Zheng initial setup/trello board check#8
npeters5 wants to merge 57 commits into
Ada-C9:masterfrom
npeters5:master

npeters5 commented Apr 3, 2018 •

edited

Loading

Uh oh!

CheezItMan commented Apr 9, 2018

Uh oh!

CheezItMan Apr 8, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

CheezItMan Apr 9, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

npeters5 commented Apr 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Apr 9, 2018

Rideshare-Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

npeters5 commented Apr 3, 2018 •

edited

Loading