Ampers Victoria/Mary

[mmlamkin]

Add due date

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We related drivers and passengers through trips ie passengers had many trips and drivers had many trips.
Describe the role of model validations in your application	The validations ensure that drivers and passengers have all of the necessary attributes before being created. ie a driver needs a name and vin and a passenger needs name and phone number, without these things they cannot be saved.
How did your team break up the work to be done?	We pair programmed during school time and divided up trello tasks by night
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We wanted to make sure we got to all of the required elements as well as have some decent styling. Our first feature we wanted to do was trip creation and the last thing we did was updating a nil trip rating for a created trip. We did not get to the "available" drivers task, unfortunately
What was one thing that your team collectively gained more clarity on after completing this assignment?	RADIO BUTTONS!
What is your Trello URL?	https://trello.com/b/3bp89jhB/rails-rideshare
What is the Heroku URL of your deployed application?	https://mary-vic-rideshare.herokuapp.com/trips

[CheezItMan]

Rideshare-Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in and both partners contributing	Check, it looks like you mostly worked on one computer, which is fine.
Answered comprehension questions	Check, RADIO BUTTON* :p
Uses named routes (like _path)	Check
RESTful routes utilized	Check, but I do notice you have a create route available to create a new trip, as well as a new_trip route, which you aren't using.
Rideshare Rails Specific Content
Table relationships	Check
Validation rules for Models	Some validations used, more is needed in the Trip model.
Business logic is in the models	You did the overall earnings, total spent and average rating in the model. I would also suggest creating a model method to assign the next available driver. That sounds like business logic to me. I also notice that all new trips are free and every driver is always available, no way to take a break in your app, but that wasn't a project requirement.
Database is seeded from the CSV files	Check, nice work.
Trello board is created and utilized in project management	Check, well done
Postgres database is used	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Very nice work here! Simple, but effective
Overall	Not bad, you have issues, but you hit the major learning goals. I like the simple and effective styling. Next time however do check your routes and eliminate unused routes.

[CheezItMan]

Just a small note, it's human nature to want to click on a user's picture, so making the picture a link as well, would be good.

[CheezItMan]

You should also validate the cost being >= 0 and the rating being 1 - 5.

[CheezItMan]

Are you assuming all drivers are always available?

I also notice all new trips are free (i.e. the cost is $0.0). How generous of you both!