lance-graph-ogar: revert OGAR pin to branch=main — one golden-image source (#648 P2)#649
Conversation
…urce) Follow-up to the codex P2 on #648. The temp-pin to OGAR rev 58a64d4 only bound lance-graph-ogar's transitive OGAR source; symbiont and cognitive-stack (root-workspace members that directly dep ogar-vocab/ontology/adapter at branch=main) still resolved a SECOND OGAR copy, so the golden image linked two OGAR versions. OGAR #152 (+#153/#154/#155) is now on main (class_ids::ALL = 79), so main == the temp-pinned superset. Reverting the four ogar-* deps to branch=main collapses every golden-image root onto ONE OGAR source: the root Cargo.lock now resolves ogar-{vocab,class-view,ontology,adapter-surrealql} at branch=main#76dcb27 (79), matching the contract mirror (79) via COUNT_FUSE. Verified: lance-graph-ogar builds (COUNT_FUSE 79==79 against OGAR main) + parity test green. (lance-graph-ogar keeps its own excluded-workspace Cargo.lock, untracked — it regenerates against branch=main on any clone.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EYvNjD8M8LMNYbRy3gq2FP
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8c2f16e56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # ogar_vocab::class_ids::ALL (79) agree via COUNT_FUSE, and symbiont / | ||
| # cognitive-stack (which also `branch = "main"` these crates) resolve the SAME | ||
| # single OGAR copy instead of a second one at a rev (codex P2 on #648). | ||
| ogar-vocab = { git = "https://github.com/AdaWorldAPI/OGAR", branch = "main" } |
There was a problem hiding this comment.
Changing these deps back to the git+...OGAR?branch=main source makes crates/cognitive-stack resolve lance-graph-ogar against its own checked-in Cargo.lock, but that lock was not updated and still pins the same branch source to #f4323c094c4535b6127b0da89440974749df585e (crates/cognitive-stack/Cargo.lock lines 5986–6010), not the root lock's #76dcb27. Because cognitive-stack is its own workspace and its documented cargo build --manifest-path crates/cognitive-stack/Cargo.toml uses that local lockfile, the activation crate now collapses onto the stale OGAR revision, whose codebook predates the 79-entry contract mirror, so parity::COUNT_FUSE fails before the golden-image binary can build; please regenerate/update that lock together with this manifest change.
Useful? React with 👍 / 👎.
2 participants
What
Follow-up to the codex P2 on #648 (merged). The temp-pin to OGAR rev
58a64d4only boundlance-graph-ogar's transitive OGAR source;symbiontand
cognitive-stack(root-workspace members that directly depogar-vocab/ogar-ontology/ogar-adapter-surrealqlatbranch = "main")still resolved a second OGAR copy — so a golden-image build linked two OGAR
versions (68-concept
mainvs 79-concept rev).Fix
OGAR #152 (+ #153/#154/#155) is now on
main(class_ids::ALL = 79), somain== the temp-pinned superset. Reverting the four
ogar-*deps tobranch = "main"collapses every golden-image root onto one OGAR source:The root
Cargo.locknow resolvesogar-{vocab,class-view,ontology,adapter-surrealql}at
branch=main#76dcb27(79), matching the contract mirror (79) viaCOUNT_FUSE.Verified
lance-graph-ogarbuilds —COUNT_FUSE 79 == 79against OGARmain— and theparity test passes.
crates/lance-graph-ogar/Cargo.lockis untracked; itregenerates against
branch=mainon any clone (so it picks upmain = 79).Depends on OGAR #152–#155 being on
main(they are).🤖 Generated with Claude Code
https://claude.ai/code/session_01EYvNjD8M8LMNYbRy3gq2FP
Generated by Claude Code