fix(env): ensure @guildpass/env builds its dist output - #355
Merged
Lakes41 merged 1 commit intoAug 21, 2026
Conversation
packages/env was missing a `prepare` script (unlike its sibling packages webhook-utils and integration-client), so `pnpm install` never built it and dist/ didn't exist for downstream consumers like apps/dashboard, causing "Module not found" errors on imports such as ./schemas/dashboard.js and ./validate.js. Also make emitDeclarationOnly explicit in tsconfig.json alongside the existing declaration/outDir settings. Fixes Adamantine-guild#334
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/env/package.jsonwas missing apreparescript (unlike its siblingswebhook-utilsandintegration-client), sopnpm installnever built it —dist/didn't exist at all for downstream consumers likeapps/dashboard, causingModule not founderrors on imports such as./schemas/dashboard.jsand./validate.js."prepare": "npm run build"topackages/env/package.jsonto match the sibling packages' convention.emitDeclarationOnly: falseexplicit inpackages/env/tsconfig.jsonalongside the existingdeclaration/outDirsettings, per the issue's acceptance criteria.Fixes #334
Test plan
packages/env/tsconfig.jsonexplicitly setsoutDir,declaration, andemitDeclarationOnlypnpm --filter @guildpass/env build→packages/env/dist/contains.jsfiles (not only.d.ts)packages/env/dist/schemas/dashboard.jsandpackages/env/dist/validate.jsexistpnpm -r build) succeeds with no "Module not found" errors inapps/dashboard