Fix invalid xbmcgui.LOGERROR in Radarr/Sonarr error paths - #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error-logging calls in the main Radarr and Sonarr flows pass
xbmcgui.LOGERROR, which does not exist. The Kodi log-level constantslive in the
xbmcmodule, notxbmcgui.common.log()forwards the level toxbmc.log(), so evaluatingxbmcgui.LOGERRORat the call site raisesAttributeError: module 'xbmcgui' has no attribute 'LOGERROR'. Thishappens on every failure path (failed lookup, add, command, or an
exception): instead of the intended error message the user gets a
script error, and the surrounding
exceptthen callslog(..., xbmcgui.LOGERROR)again, raising a second uncaughtAttributeError. The happy path is unaffected.
The helper/test functions already use the correct
xbmc.LOGERROR(for example radarr.py:28, 45, 51), so this is an inconsistency.
Fix: use
xbmc.LOGERRORat the affected sites.xbmcis alreadyimported in both files, so no other change is needed.
Affected lines:
Verified on Kodi 22:
xbmcgui.LOGERRORraises AttributeError,xbmc.LOGERRORis 3, and calling the addon'scommon.log(msg, xbmc.LOGERROR)works.