Repository navigation
Opt-in fail-closed audit (LLM_SECRETS_AUDIT_STRICT) — ADR 0010 - #28
Merged
Merged
Conversation
Secret-access audits (exec.inject, mcp.peek) now route through lease::record, which applies the ADR 0010 policy: fail-open by default (swallow the error with a stderr warning) and fail-closed under LLM_SECRETS_AUDIT_STRICT. Corrects the audit() doc comment to match the real default and adds a unit test for the policy decision. Closes #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the decision in ADR 0010. Closes #26.
Access-path audits route through
lease::record(): fail-open by default (warn on failure, continue), fail-closed underLLM_SECRETS_AUDIT_STRICT=1. Default behaviour unchanged apart from the new warning. Unit test covers the policy; manual check confirms default warns-and-continues while strict refuses (verified by sabotaging the audit sink).